Skip to content

[incremental compiler] Cannot compile expression containing extension type #53036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
annagrin opened this issue Jul 25, 2023 · 5 comments
Closed

[incremental compiler] Cannot compile expression containing extension type #53036

annagrin opened this issue Jul 25, 2023 · 5 comments
Assignees
@johnniwinther
Labels
feature-extension-types Implementation of the extension type feature front-end-expression-compilation legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@annagrin
Copy link
Contributor

annagrin commented Jul 25, 2023 •
edited
Loading

Expression compilation of an expression that uses an extension type currently fails to find the extension type (do we need to add an import self as self to the synthetic library that is created for expression compilation in the incremental compiler?)

Example:

image
@annagrin
Copy link
Contributor Author

/cc @johnniwinther I played with expression compilation and extension types and discovered this issue. Would be great to resolve it so we can see the current state of the expression evaluation for extension types on VM and web (it would help us design debugging support for extension types)

@johnniwinther
Copy link
Member

Extension types are still not supported when loaded from dill files. I'll work on it.

@johnniwinther johnniwinther self-assigned this Jul 26, 2023
@johnniwinther johnniwinther added feature-extension-types Implementation of the extension type feature legacy-area-front-end Legacy: Use area-dart-model instead. labels Jul 26, 2023
@annagrin
Copy link
Contributor Author

annagrin commented Jul 26, 2023 •
edited
Loading

Extension types are still not supported when loaded from dill files. I'll work on it.

Thanks! Forgot to mention - this is happening for both web expression compiler (that loads dill files) and vm (not sure what it does really). I haven't tried it for web with the frontend server though (this one does not load dill files I think?). I will try it out and update.

copybara-service bot pushed a commit that referenced this issue Jul 28, 2023
@johnniwinther
[cfe] Support extension types from dill
bbbf6b9 
In response to #53036

Change-Id: I676f5086028b88023b37379d674d66a8908709e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316580
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
@johnniwinther
Copy link
Member

https://dart-review.googlesource.com/c/sdk/+/316580 has landed support for extension types from dill. @annagrin can you check if the problem persists?

@annagrin
Copy link
Contributor Author

annagrin commented Aug 7, 2023

I can compile (as as B).getter expression now, thanks!

@annagrin annagrin closed this as completed Aug 7, 2023
@annagrin annagrin mentioned this issue Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
feature-extension-types Implementation of the extension type feature front-end-expression-compilation legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnniwinther @annagrin