Skip to content

Extension type failures on new tests - syntax not fully supported yet #53074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whesse opened this issue Jul 31, 2023 · 1 comment
Closed

Extension type failures on new tests - syntax not fully supported yet #53074

whesse opened this issue Jul 31, 2023 · 1 comment
Assignees
@johnniwinther
Labels
cfe-feature-extension-types Implement extension types feature in the CFE feature-extension-types Implementation of the extension type feature legacy-area-front-end Legacy: Use area-dart-model instead.

Comments

@whesse
Copy link
Contributor

whesse commented Jul 31, 2023

New co19 tests for extension types have some failures, where the support is not complete yet.

There are new test failures on [co19] Roll co19 to 3f9d5d1f9ea353b61982236624809f930323dbf7.

The tests

co19/LanguageFeatures/Extension-types/syntax_A03_t01 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A04_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A04_t06 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A05_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A05_t02 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A06_t01 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A07_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A07_t01 Crash (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A08_t01 MissingCompileTimeError (expected Pass)
co19/LanguageFeatures/Extension-types/syntax_A10_t01 CompileTimeError (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Extension-types/syntax_A06_t01 Fail (expected Pass)
pkg/front_end/test/parser_all/tests/co19/src/LanguageFeatures/Extension-types/syntax_A07_t01 Fail (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-unittest-asserts-release-linux
dart2js-hostasserts-linux-chrome-unsound
dart2js-hostasserts-linux-d8
dart2js-linux-chrome
@whesse whesse added the legacy-area-front-end Legacy: Use area-dart-model instead. label Jul 31, 2023
@johnniwinther johnniwinther self-assigned this Aug 1, 2023
@johnniwinther johnniwinther added the feature-extension-types Implementation of the extension type feature label Oct 3, 2023
@johnniwinther johnniwinther added the cfe-feature-extension-types Implement extension types feature in the CFE label Oct 13, 2023
copybara-service bot pushed a commit that referenced this issue Oct 18, 2023
@chloestefantsova
[cfe] Report error on representation type modifiers and missing type
be36f24 
This CL addresses some of the failures reported in
#53074

Part of #49731

Change-Id: I2b23a9d0c095856139563f9e500e88bebadc1ce3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331042
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
@johnniwinther
Copy link
Member

All fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
cfe-feature-extension-types Implement extension types feature in the CFE feature-extension-types Implementation of the extension type feature legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whesse @johnniwinther