Skip to content

migrate TargetKind enum to classes #53368

Closed
@pq

Description

@pq

Follow-up from: #49796. This is required to evolve support for existing and upcoming language features and will unblock:

Background: an earlier attempt at this refactoring was reverted in 813ca7f for appearing to cause a measurable performance regression.

813339e is a trimmed down version of that attempted change; with it landed, we'll monitor any performance impact. If there is no impact we'll publish a new version of package:meta (bumping minor version) and see if any unexpected ecosystem impact shakes out.

Activity

added
P2A bug or feature request we're likely to work on
devexp-pkg-metaIssues related to package:meta
on Aug 28, 2023
self-assigned this
on Aug 28, 2023
pq

pq commented on Sep 6, 2023

@pq
MemberAuthor

UPDATE package:meta v1.10.0 with this change has been published. Assuming no ecosystem issues shake out, we'll go ahead and start adding new TargetKinds.

pq

pq commented on Sep 8, 2023

@pq
MemberAuthor

8a5ddec adds the first new target kind (for extension types). We haven't published that yet so we can still back it out but it looks like this migration may be in the clear. 🤞

pq

pq commented on Sep 12, 2023

@pq
MemberAuthor

This feels done. If we see any issues we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2A bug or feature request we're likely to work ondevexp-pkg-metaIssues related to package:metalegacy-area-analyzerUse area-devexp instead.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @pq

      Issue actions

        migrate `TargetKind` enum to classes · Issue #53368 · dart-lang/sdk