Skip to content

[dart fix] rename change not suggested for casts #54617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devoncarew opened this issue Jan 14, 2024 · 0 comments
Open

[dart fix] rename change not suggested for casts #54617

devoncarew opened this issue Jan 14, 2024 · 0 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-dartfix Issues with the dartfix package devexp-data-driven-fixes Issues with the analysis server's support for data-driven fixes P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@devoncarew
Copy link
Member

When contributing some class rename dart fix fixes for package:web, a rename is not offered for as casts:

import 'package:web/web.dart';

void main() {
  final HtmlDocument foo = document; // Rename (from HtmlDocument => Document) _is_ offered here

  final doc = document as HtmlDocument; // Rename not offered here (but should be)

  final div = doc.querySelector('div')!;
  div.text = 'Text set at ${DateTime.now()}';
}

More context in dart-lang/web#141.

cc @keertip

@mraleph mraleph added legacy-area-analyzer Use area-devexp instead. devexp-dartfix Issues with the dartfix package labels Jan 16, 2024
@pq pq added the P3 A lower priority bug or feature request label Jan 16, 2024
@keertip keertip added devexp-data-driven-fixes Issues with the analysis server's support for data-driven fixes type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Mar 15, 2024
@bwilkerson bwilkerson added area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. and removed legacy-area-analyzer Use area-devexp instead. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-dartfix Issues with the dartfix package devexp-data-driven-fixes Issues with the analysis server's support for data-driven fixes P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

5 participants