Skip to content

Failures on [ CLI ] Fix issue where 'dart build' would fail to find the 'dart' when run from PATH #56306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
a-siva opened this issue Jul 23, 2024 · 0 comments
Closed

Failures on [ CLI ] Fix issue where 'dart build' would fail to find the 'dart' when run from PATH #56306

a-siva opened this issue Jul 23, 2024 · 0 comments
Assignees
@bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dart-cli-bug Issues related to the 'dart bug' tool gardening triaged Issue has been triaged by sub team type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@a-siva
Copy link
Contributor

a-siva commented Jul 23, 2024

There are new test failures on [ CLI ] Fix issue where 'dart build' would fail to find the 'dart' when run from PATH.

The tests

pkg/dartdev/test/sdk_from_path_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-win-arm64
unittest-asserts-release-win-x64
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) gardening dart-cli-bug Issues related to the 'dart bug' tool labels Jul 23, 2024
@a-siva a-siva added the triaged Issue has been triaged by sub team label Jul 24, 2024
@bkonyi bkonyi mentioned this issue Aug 16, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Aug 22, 2024
@bkonyi
[stable] [ CLI ] Fix issue where Platform.executable on Windows could…
3f7db41 
… return 'dart'

When running the VM from PATH using 'dart', Platform.executable could report
the process name as 'dart' instead of 'dart.exe'. This change updates dartdev
to handle this case so the checkArtifactExists call doesn't fail to find the
'dart' binary.

Fixes #56306

[stable] [ CLI ] Fix issue where 'dart build' would fail to find the 'dart' when run from PATH

Fixes #56080

Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/377542, https://dart-review.googlesource.com/c/sdk/+/376860
Cherry-pick-request: #56500
Change-Id: Ic30145309a307204d83353759d7b6c5da07faaa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381041
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>
Reviewed-by: Derek Xu <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dart-cli-bug Issues related to the 'dart bug' tool gardening triaged Issue has been triaged by sub team type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-siva @bkonyi