Broken android build #57084
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
legacy-area-front-end
Legacy: Use area-dart-model instead.
Comments
|
Hi @cyberpwnn, I don't think this is related to |
|
@jensjoha Can you determine where this problem comes from? |
|
So looking briefly at the code my guess is that something like this is happening:
All in all I'd say it's a VM issue, not a CFE one. /cc @alexmarkov who seems to have done a lot with these files. |
|
Thank you, @jensjoha ! However, I'm struggling to create a repro for this bug. As far as I understand, fields used in constants should be |
alexmarkov
added
the
area-vm
copybara-service bot
pushed a commit
that referenced
this issue
Nov 14, 2024
TEST=ci Issue: #57084 Change-Id: Icacf44847cf5f53c256c62390c4c9ddfc0b80646 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395400 Auto-Submit: Alexander Markov <[email protected]> Reviewed-by: Slava Egorov <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
|
I don't know. It seems that it shouldn't be possible to have |
|
@cyberpwnn Can you provide a sample which can be used to reproduce the crash? |
alexmarkov
added
the
needs-info
|
@johnniwinther to the rescue on this one, being able to easily create a field in a constant marked as isCovariantByClass. abstract class A<T> {
T get field;
void set field(T value);
}
class C<T> implements A<T> {
@override
final T field;
const C(this.field);
@override
set field(value) => throw '';
}
const c = C<String>('');
void main() {
print(c);
}which - with some instrumentation to print some nice stuff - gives this: which - via Changing the main to void main() {
c;
() {
print(c);
}();
}we crash at the in |
jensjoha
removed
the
needs-info
|
Thank you for the reproduction, @jensjoha and @johnniwinther . Kernel for this example: I'm still wondering if Description of this flag: sdk/pkg/kernel/lib/src/ast/members.dart Lines 388 to 392 in 1293500 There is no implicit setter associated with that @johnniwinther WDYT? I can fix this bug by ignoring |
copybara-service bot
pushed a commit
that referenced
this issue
Dec 17, 2024
…it setters TEST=pkg/vm/testcases/transformations/type_flow/transformer/regress_57084.dart Bug: #57084 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/396300 Cherry-pick-request: #59692 Change-Id: Ib7c5ba7d1e15b35f22c39a437bf8b43094eea5eb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399624 Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: