test_types_in_equals false positive

[alexeieleusis]

bool operator ==(Object other) {
    if (other is! Foo) return false;
   ...
}

[srawlins]

To clarify the example:

class Foo {
  bool b = false;
  @override
  bool operator ==(Object other) {
    if (other is! Foo) return false;
    Foo otherFoo = other as Foo;
    return otherFoo.b;
  }

  @override
  int get hashCode => 7;
}

results in a lint report on line 6.

[asashour]

Should be closed, as discussed in dart-archive/linter#2834. With null-safety, the issue is not relevant.

[pq]

Agreed. Thanks!