Skip to content

enhanced enums support for avoid_renaming_method_parameters #58587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #58582
pq opened this issue Dec 6, 2021 · 1 comment · Fixed by dart-archive/linter#3246
Closed
Tracked by #58582

enhanced enums support for avoid_renaming_method_parameters #58587

pq opened this issue Dec 6, 2021 · 1 comment · Fixed by dart-archive/linter#3246
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature

Comments

@pq
Copy link
Member

pq commented Dec 6, 2021

No description provided.

@pq
Copy link
Member Author

pq commented Jan 27, 2022

  test_rename() async {
    await assertDiagnostics(r'''
class C {
  int f(int f) => f;
}
enum A implements C {
  a,b,c;
  @override
  int f(int x) => x;
}
''', [
      lint('avoid_renaming_method_parameters', 28, 8), // todo(pq): update index
    ]);
  }

Tip-of-trunk fails w/:

package:test_api                                       fail
test/rule_test_support.dart 216:7                      LintRuleTest.assertDiagnostics
===== asynchronous gap ===========================
test/rules/avoid_renaming_method_parameters.dart 27:5  AvoidRenamingMethodParametersTest.test_rename

Expected but did not find:
  avoid_renaming_method_parameters [28, 8]

Found but did not expect:
  HintCode.OVERRIDE_ON_NON_OVERRIDING_METHOD [82, 1, The method doesn't override an inherited method.]

@scheglov: I don't think the HintCode.OVERRIDE_ON_NON_OVERRIDING_METHOD is correct?

@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-new-language-feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants