Skip to content

no_leading_underscores_for_local_identifiers tests should include variable patterns #59063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srawlins opened this issue Mar 9, 2023 · 1 comment · Fixed by dart-archive/linter#4133
Assignees
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-set-recommended P2 A bug or feature request we're likely to work on
Milestone

Comments

@srawlins
Copy link
Member

srawlins commented Mar 9, 2023

Child issue of #58837

I think there should be a test case like:

switch ((1, 2)) {
  case (var _a, var _b): ...
}

in which the lint rule would report that the variables shouldn't start with underscore.

Also a destructuring example:

(int?, int?) position = ...

var (_x, _y) = position;
@pq pq self-assigned this Mar 10, 2023
@pq pq added this to the Dart 3 beta 3 milestone Mar 10, 2023
@pq
Copy link
Member

pq commented Mar 10, 2023

Thanks a million Sam!

@pq pq added the P2 A bug or feature request we're likely to work on label Mar 10, 2023
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 19, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. linter-set-recommended P2 A bug or feature request we're likely to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants