Skip to content

[CP] DevTools 2.40.3 #59884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elliette opened this issue Jan 10, 2025 · 4 comments
Closed

[CP] DevTools 2.40.3 #59884

elliette opened this issue Jan 10, 2025 · 4 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@elliette
Copy link
Contributor

elliette commented Jan 10, 2025 •
edited
Loading

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/404061

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/404061

Issue Description

The DevTools analytics is missing data in its analytics to distinguish whether events are coming from the new or legacy inspector. This is because the parameter that was added is a boolean, but Google Analytics 4 only supports string or int values.

Why cherry-pick

Without being able to distinguish between the new and legacy inspector events, we are unable to monitor the rollout of the new inspector and mitigate any issues that arise.

Risk

Low

Issue link(s)

flutter/devtools#8690
@elliette elliette added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 10, 2025
@dart-github-bot
Copy link
Collaborator

Summary: DevTools 2.40.3 cherry-pick to stable. Issue details and justification pending.

@dart-github-bot dart-github-bot added area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Jan 10, 2025
@devoncarew devoncarew added area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). and removed area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Jan 15, 2025
@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Jan 22, 2025
@itsjustkevin
Copy link
Contributor

Cherry-pick approved.

@athomas athomas removed the cherry-pick-approved Label for approved cherrypick request label Jan 28, 2025
@athomas
Copy link
Member

athomas commented Jan 28, 2025 •
edited
Loading

This CP conflicts with #59898. I'm closing it (please re-open if you disagree).

Sorry, other pick is for beta. I got confused.

@athomas athomas closed this as completed Jan 28, 2025
@athomas athomas added cherry-pick-denied Label for denied cherrypick request cherry-pick-approved Label for approved cherrypick request and removed cherry-pick-denied Label for denied cherrypick request labels Jan 28, 2025
copybara-service bot pushed a commit that referenced this issue Jan 29, 2025
@elliette
[stable] Cherry-pick DevTools 2.40.3 into the SDK stable branch.
6cdfe9c 
Bug: #59884
Change-Id: I259f06ed2dffe52937007c8251111e502fc974d4
Cherry-pick: flutter/devtools@v2.40.2...2.40.3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404061
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Kenzie Davisson <[email protected]>
@athomas
Copy link
Member

athomas commented Jan 30, 2025

Released in 3.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@devoncarew @vsmenon @itsjustkevin @mit-mit @athomas @elliette @dart-github-bot