Update changelog.md to mention new assert with message feature #28156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lrhn @floitschG can you review, please? |
floitschG
reviewed
Dec 20, 2016
| * The `assert()` statement has been expanded to support an optional second | ||
| `message` argument (SDK issue [27342](https://github.com/dart-lang/sdk/issues/27342)). | ||
|
|
||
| The message is display if the assert fails. It can be any object, and it |
|
LGTM (with one typo). |
|
Thanks, typo fixed |
lrhn
reviewed
Dec 20, 2016
|
|
||
| * The `assert()` statement has been expanded to support an optional second | ||
| `message` argument (SDK issue [27342](https://github.com/dart-lang/sdk/issues/27342)). | ||
|
|
There was a problem hiding this comment.
Maybe use #24213 as the issue number.
lrhn
reviewed
Dec 20, 2016
| 'file:///Users/mit/tmp/tool/bin/main.dart': Failed assertion: line 9 pos 10: | ||
| 'configFile != null': Tool config missing. Please see https://goo.gl/k8iAi for details. | ||
| #0 _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:33) | ||
| #1 _AssertionError._throwNew (dart:core-patch/errors_patch.dart:29) |
There was a problem hiding this comment.
We should hide internal methods in the stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28134