Draft PR for introducing a way to ban http #40549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Feb 9, 2020
sdk/lib/_http/http_impl.dart
Outdated
| @@ -2285,6 +2288,11 @@ class _HttpClient implements HttpClient { | |||
| } | |||
|
|
|||
| bool isSecure = (uri.scheme == "https"); | |||
| bool isMobileClient = Platform.isAndroid || Platform.isIOS; | |||
There was a problem hiding this comment.
If you remove the restriction that the flag only works on mobile platforms, then I suspect it will be easier to write tests. A regular Dart program could just install an HttpOverrides in a zone with the flag flipped, and check that the right exception is thrown.
There was a problem hiding this comment.
There are two reasons for including a mobile client distinction:
- We intend to flip the default in google3 but only for mobile. The default should be
allowfor non-mobile applications even in google3. Perhaps, this can be solved by having defaults per Platform. - It reflects the principle of the change more accurately. On iOS and Android, we should not be asking the apps to install an Override to get this behavior. Both OSes ban cleartext HTTP by default for their native apps.
I introduced platform specific defaults to capture both points and removed the isMobileClient check.
| @@ -2151,6 +2152,13 @@ class _HttpClient implements HttpClient { | |||
|
|
|||
| _HttpClient(this._context); | |||
|
|
|||
| static bool get _isHttpAllowedByDefault { | |||
| if (Platform.isIOS) return true; | |||
There was a problem hiding this comment.
Maybe opposite value, i.e. false?
There was a problem hiding this comment.
That would be a breaking change upstream.
I would be happy to do it but @mit-mit needs to agree.
|
This requires a rewrite. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal: #40548
Tests and documentation is missing as it is a POC.