Fix Socket remoteAddress obtaining on Win32 #51778

[slonm]

Looks getpeername() is broken when it used after AcceptEx(). I found a couple mentions of such issue but it's strange that they are pretty old:

https://www.codeproject.com/Messages/540371/Re-Win2K-AcceptEx-amp-amp-getpeername
https://alt.winsock.programming.narkive.com/ZUX8KVbu/so-update-accept-context-usage

I've implemented the workaround and call GetAcceptExSockaddrs() instead of getpeername() immediately after socket connection accept.

Now Unit test tests\standalone_2\io\socket_info_ipv6_test.dart is passed without errors.

[slonm]

Initial issue #51778

[copybara-service]

Thank you for your contribution. This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/294220

Please wait for a developer to review your code review at the above link. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. You can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code and they will help you. You can also push additional commits to this pull request to update the code review.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[mit-mit]

Hi @slonm thanks for the contribution; can you please rebase it?

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[slonm]

Hi @mit-mit, I've resolved the conflict but not sure whether I've done things right regarding rebasing. Let me know if there is something wrong

[mit-mit]

Thanks. Stay tuned for comments in the dart-review link.

[brianquinlan]

@slonm There are comments at https://dart-review.googlesource.com/c/sdk/+/294220

[slonm]

@brianquinlan - should I do something with it?

[brianquinlan]

@slonm That's up to you. There are two ways that we can go here:

1. You address the comments in the code review and, after we reach a consensus, we commit your change.
2. We abandon your pull request, I recreate it and then send it to another Dart developer for review.

Let me know which you'd prefer.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[slonm]

Performed code review. Agreed with most of suggestions

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.

[copybara-service]

https://dart-review.googlesource.com/c/sdk/+/294220 has been updated with the latest commits from this pull request.