GeneratorBuilder flag for "part of" without "library". #179
Conversation
| @@ -33,6 +33,12 @@ | |||
| ``` | |||
|
|
|||
| In Dart SDK `>=1.25.0` this can be relaxed as `part of` can refer to a path. | |||
| To opt-in, `GeneratorBuilder` now has a new flag, `requireLibraryDirective`. | |||
There was a problem hiding this comment.
Just an idea, but you can check the SDK version using Platform.version from dart:io, and we could make the default be based on that even? That would also likely require a dependency on pub_semver but that should be ok.
There was a problem hiding this comment.
Fwiw I actually like this idea, but it hasn't technically landed yet even at -dev. Maybe we can set the default based on that once 1.25.0 lands officially?
There was a problem hiding this comment.
Sounds good - if it hasn't landed officially in any release there is no sdk constraint we can set either right.... so we can't really release this feature at all until then.
There was a problem hiding this comment.
I figured adding this flags gives users the chance to make that choice for themselves versus waiting for us to do the right thing ;)
There was a problem hiding this comment.
Also I forgot about the fact that you need to update your sdk constraint if you are publishing these files as part of a package, so using it automatically is a no-go.
What we could do though is just add the sdk constraint in this package?
There was a problem hiding this comment.
But ya in any case adding the flag seems like an easy workaround to sidestep the issue
Closes #157.
Closes #138.
This approach will not lock-in all future users of
source_gento an unreleased1.25.0. We can flip the default value in a future (breaking) release./cc @davidmorgan