Skip to content

package:test should not depend on Dart SDK internals #2210

@mkustermann

Description

@mkustermann

Currently package:test seems to depend on an internal location and name of an AOT-compiled snapshot of e.g. dart2wasm compiler, see pkgs/test_core/lib/src/runner/wasm_compiler_pool.dart:

      var platformDill =
          p.join(sdkRoot, 'lib', '_internal', 'dart2wasm_platform.dill');
      var dartPrecompiledRuntimePath = p.join(sdkRoot, 'bin', 'dartaotruntime');
      var dart2wasmSnapshotPath =
          p.join(sdkRoot, 'bin/snapshots', 'dart2wasm_product.snapshot');
      var process = await Process.start(dartPrecompiledRuntimePath, [
        dart2wasmSnapshotPath,
        '--dart-sdk=$sdkRoot',
        '--platform=$platformDill',
        '--packages=${(await packageConfigUri).path}',
        for (var experiment in enabledExperiments)
          '--enable-experiment=$experiment',
        wrapperPath,
        outWasmPath,
      ]);

3rd parties should not depend on <dart-sdk>/lib/_internal/* or <dart-sdk/bin/snapshots/*.

Why can package:test not use dart compile wasm instead?

/cc @kevmoo

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions