Skip to content

Move debug functionality to a --debug flag #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 24, 2019
Merged

Move debug functionality to a --debug flag #1083

merged 6 commits into from
Sep 24, 2019

Conversation

willdrach-wk
Copy link
Contributor

Fixes #1082

@grouma
Copy link
Member

grouma commented Sep 23, 2019

Note I'll hold off on reviewing this until you ping me / remove the WIP tag.

@willdrach-wk willdrach-wk changed the title WIP - Move debug functionality to a --debug flag Move debug functionality to a --debug flag Sep 24, 2019
@willdrach-wk willdrach-wk marked this pull request as ready for review September 24, 2019 18:47
@willdrach-wk
Copy link
Contributor Author

@grouma this should be ready for a first pass of review

@natebosch natebosch requested a review from grouma September 24, 2019 18:57
grouma
grouma reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@grouma grouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a CHANGELOG entry and bump the pubspec versions

@willdrach-wk
Copy link
Contributor Author

Changelogs updated

grouma
grouma reviewed Sep 24, 2019
View reviewed changes
Copy link
Member

@grouma grouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but LGTM. Also looks like you have some format issues.

@willdrach-wk
Copy link
Contributor Author

@grouma CONTRIBUTING.md says not to format, is that out of date?

@grouma
Copy link
Member

grouma commented Sep 24, 2019

@grouma CONTRIBUTING.md says not to format, is that out of date?

Super out of date!

@willdrach-wk
Copy link
Contributor Author

Good to know!

@jakemac53
Copy link
Contributor

jakemac53 commented Sep 24, 2019 •
edited
Loading

@grouma CONTRIBUTING.md says not to format, is that out of date?

🤣 (we should really update that)

@willdrach-wk willdrach-wk mentioned this pull request Sep 24, 2019
Merged
@willdrach-wk
Copy link
Contributor Author

This is ready whenever you guys are ready @grouma @jakemac53

@grouma grouma merged commit d490ab1 into dart-lang:master Sep 24, 2019
@willdrach-wk willdrach-wk deleted the decouple-debug branch September 26, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanweible-wf evanweible-wf evanweible-wf approved these changes

@grouma grouma grouma approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser/VM debug modes should be enableable outside of --pause-after-load
5 participants
@willdrach-wk @grouma @jakemac53 @evanweible-wf @googlebot