Serve dart2wasm source map files #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart2wasm generates a source map file at the same location with the .wasm file. Serve it to help with debugging in the browser with `--pause-after-load`. Note: somehow the source map file is not requested by the browser when testing with just `test -p chrome -c dart2wasm` (without `--pause-after-load` and manually adding breakpoints). I'm investigating why the source map isn't requested by default.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
sigurdm
approved these changes
Aug 26, 2025
|
CI failure seems unrelated, #2529 also has the same failure. Should I merge this? |
|
Yeah, seems to be failing at main as well Probably fine to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart2wasm generates a source map file at the same location with the .wasm file. Serve it to help with debugging in the browser with
--pause-after-load.Note: somehow the source map file is not requested by the browser when testing with just
test -p chrome -c dart2wasm(without--pause-after-loadand manually adding breakpoints). I'm investigating why the source map isn't requested by default. When I run the same failing test with-c dart2jsthe source map is used.