VMScript URI does not uniquely identify a script #437

Closed

dart-archive/coverage

Closed

VMScript URI does not uniquely identify a script#437

dart-archive/coverage

Assignees

Labels

package:coveragetype-bug

In at least one place in the code, we use VMScript.uri as a proxy for the ID under the assumption that they map 1:1.

This is not a safe assumption.

added

self-assigned this

MemberAuthor

@rmacnak-google @jason-simmons

added a commit that references this issue

Prefix scripts from core builtin libraries so the URIs are unique.

mentioned this

Don't use flutter_test in animated_icons_private_test. flutter/flutter#13917

added a commit that references this issue

Don't use flutter_test in animated_icons_private_test. (#13917)

This was failing the coverage tool when running on animated_icons_private_test, stack trace was:

unhandled error during test:
/b/build/slave/Linux/build/flutter/packages/flutter/test/material/animated_icons_private_test.dart
Bad state: Couldn't find line and column for token 246 in package:flutter/src/material/animated_icons/animated_icons.dart.
05:45 +860 ~2 -1: loading /b/build/slave/Linux/build/flutter/packages/flutter/test/material/animated_icons_private_test.dart [E]
  Bad state: Couldn't find line and column for token 246 in package:flutter/src/material/animated_icons/animated_icons.dart.
  package:flutter_tools/src/test/flutter_platform.dart 399   _FlutterPlatform._startTest
  ===== asynchronous gap ===========================
  dart:async/future_impl.dart 22                             _Completer.completeError
  package:flutter_tools/src/test/flutter_platform.dart 403   _FlutterPlatform._startTest
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1045                                  _CustomZone.registerUnaryCallback
  dart:async-patch/async_patch.dart 30                       _asyncThenWrapperHelper
  package:flutter_tools/src/test/flutter_platform.dart 141   _FlutterPlatform._startTest
  package:flutter_tools/src/test/flutter_platform.dart 134   _FlutterPlatform.loadChannel
  package:test/src/runner/plugin/platform.dart 62            PlatformPlugin.load
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1034                                  _CustomZone.registerCallback
  dart:async/zone.dart 924                                   _CustomZone.bindCallback
  dart:async/schedule_microtask.dart 148                     scheduleMicrotask
  dart:async/future.dart 198                                 new Future.microtask
  package:test/src/runner/plugin/platform.dart 59            PlatformPlugin.load
  package:test/src/runner/loader.dart 253                    Loader.loadFile.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1045                                  _CustomZone.registerUnaryCallback
  dart:async-patch/async_patch.dart 30                       _asyncThenWrapperHelper
  package:test/src/runner/loader.dart 247                    Loader.loadFile.<fn>
  package:test/src/runner/load_suite.dart 79                 new LoadSuite.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1034                                  _CustomZone.registerCallback
  dart:async/zone.dart 924                                   _CustomZone.bindCallback
  dart:async/schedule_microtask.dart 148                     scheduleMicrotask
  dart:async/future.dart 198                                 new Future.microtask
  package:test/src/runner/load_suite.dart 77                 new LoadSuite.<fn>.<fn>
  package:test/src/utils.dart 329                            invoke
  package:test/src/runner/load_suite.dart 77                 new LoadSuite.<fn>
  package:test/src/backend/invoker.dart 351                  Invoker._onRun.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1034                                  _CustomZone.registerCallback
  dart:async/zone.dart 924                                   _CustomZone.bindCallback
  dart:async/schedule_microtask.dart 148                     scheduleMicrotask
  dart:async/future.dart 198                                 new Future.microtask
  package:test/src/backend/invoker.dart 350                  Invoker._onRun.<fn>.<fn>.<fn>
  dart:async/future.dart 174                                 new Future.<fn>
  package:stack_trace/src/stack_zone_specification.dart 209  StackZoneSpecification._run
  package:stack_trace/src/stack_zone_specification.dart 119  StackZoneSpecification._registerCallback.<fn>
  dart:async/zone.dart 1116                                  _rootRun
  dart:async/zone.dart 1001                                  _CustomZone.run
  dart:async/zone.dart 901                                   _CustomZone.runGuarded
  dart:async/zone.dart 926                                   _CustomZone.bindCallback.<fn>
  package:stack_trace/src/stack_zone_specification.dart 209  StackZoneSpecification._run
  package:stack_trace/src/stack_zone_specification.dart 119  StackZoneSpecification._registerCallback.<fn>
  dart:async/zone.dart 1120                                  _rootRun
  dart:async/zone.dart 1001                                  _CustomZone.run
  dart:async/zone.dart 901                                   _CustomZone.runGuarded
  dart:async/zone.dart 926                                   _CustomZone.bindCallback.<fn>
  dart:async-patch/timer_patch.dart 21                       Timer._createTimer.<fn>
  dart:isolate-patch/timer_impl.dart 366                     _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 394                     _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 151                  _RawReceivePortImpl._handleMessage
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1034                                  _CustomZone.registerCallback
  dart:async/zone.dart 924                                   _CustomZone.bindCallback
  dart:async/timer.dart 52                                   new Timer
  dart:async/timer.dart 90                                   Timer.run
  dart:async/future.dart 172                                 new Future
  package:test/src/backend/invoker.dart 350                  Invoker._onRun.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1034                                  _CustomZone.registerCallback
  dart:async/zone.dart 924                                   _CustomZone.bindCallback
  dart:async/schedule_microtask.dart 148                     scheduleMicrotask
  dart:async/future.dart 198                                 new Future.microtask
  package:test/src/backend/invoker.dart 337                  Invoker._onRun.<fn>.<fn>
  dart:async/zone.dart 1120                                  _rootRun
  dart:async/zone.dart 1001                                  _CustomZone.run
  dart:async/zone.dart 1467                                  runZoned
  package:test/src/backend/invoker.dart 337                  Invoker._onRun.<fn>
  package:stack_trace/src/chain.dart 101                     Chain.capture.<fn>
  dart:async/zone.dart 1120                                  _rootRun
  dart:async/zone.dart 1001                                  _CustomZone.run
  dart:async/zone.dart 1467                                  runZoned
  package:stack_trace/src/chain.dart 99                      Chain.capture
  package:test/src/backend/invoker.dart 336                  Invoker._onRun
  package:test/src/backend/live_test_controller.dart 188     LiveTestController._run
  package:test/src/backend/live_test_controller.dart 40      _LiveTest.run
  dart:async/future.dart 200                                 new Future.microtask.<fn>
  dart:async/zone.dart 1120                                  _rootRun
  dart:async/zone.dart 1001                                  _CustomZone.run
  dart:async/zone.dart 928                                   _CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                      _microtaskLoop
  dart:async/schedule_microtask.dart 50                      _startMicrotaskLoop
  dart:isolate-patch/isolate_patch.dart 99                   _runPendingImmediateCallback
  dart:isolate-patch/isolate_patch.dart 152                  _RawReceivePortImpl._handleMessage

added a commit that references this issue

Use VMScriptRef to identify VM scripts, not URI

mentioned this

Use VMScriptRef to identify VM scripts, not URI dart-archive/coverage#216

mentioned this

Wish for a way to test non-public APIs dart-lang/sdk#31775

added a commit that references this issue

on May 14, 2018

Don't use flutter_test in animated_icons_private_test. (flutter#13917)

mentioned this

on Oct 18, 2018

VM, package:vm_service_client and/or package:coverage fail to find source line/column dart-lang/sdk#34841

added a commit that references this issue

on Oct 19, 2018

Use VMScriptRef to identify VM scripts, not URI

closed this as completedin #216

on Oct 19, 2018

added a commit that references this issue

on Oct 19, 2018

Use VMScriptRef to identify VM scripts, not URI (#216)

5 remaining items

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

cbracken

Labels

package:coveragetype-bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

Use VMScriptRef to identify VM scripts, not URIdart-archive/coverage

Participants