Skip to content

Save events locally, regardless of analytics opt-in status #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Save events locally, regardless of analytics opt-in status #11

wants to merge 18 commits into from

Conversation

eliasyishak
Copy link
Contributor

Waiting for decision; if approved, this will save all analytics events locally on the user's machine, even if they have opted out of analytics.

This will enable in-IDE surveys for user's even if they have opted out – this would ideally be okay because nothing has been sent to GA4 and the user has to willingly click into the survey after being prompted

- Events can have a maximum of 25 user properties
- User property names must be 24 characters or fewer
- User property values must be 36 characters or fewer (only for `tool` name)
- Event names must be 40 characters or fewer, may only contain alpha-numeric characters and underscores, and must start with an alphabetic character
@eliasyishak eliasyishak changed the title Check for telemetry status after saving locally Save events locally, regardless of analytics opt-in status Feb 28, 2023
@eliasyishak eliasyishak closed this Mar 1, 2023
@eliasyishak eliasyishak deleted the always-save-logs branch March 1, 2023 20:57
@bwilkerson
Copy link
Member

Does this mean that we can't store to the log file if we aren't reporting the analytics?

@eliasyishak
Copy link
Contributor Author

This is my mistake, I had to delete the other branch that had the change on the old package name. Reopening and going to rebase

@eliasyishak eliasyishak restored the always-save-logs branch March 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants