Skip to content

Move credentials inside package #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 28, 2023
Merged

Move credentials inside package #13

merged 14 commits into from
Feb 28, 2023

Conversation

eliasyishak
Copy link
Contributor

The Measurement ID and API secrets for the package have been moved into the package so client tools don't need to pass it in; example below of the parameters used now

final Analytics analytics = Analytics(
  tool: DashTool.flutterTools,
  flutterChannel: 'ey-test-channel',  // Optional Param
  flutterVersion: 'Flutter 3.6.0-7.0.pre.47',  // Optional Param
  dartVersion: 'Dart 2.19.0',
);

@eliasyishak
adding event for analyzer startup
db28a4e
@eliasyishak
switching from hyphens to underscore; GA4 restriction
f83f19c
@eliasyishak
making eventData nullable for events that don't need it
9d0dd2e
@eliasyishak
Update dash_analytics_example.dart
f105267
@eliasyishak
added test to check for limitations below
9825399 
- Events can have a maximum of 25 user properties
- User property names must be 24 characters or fewer
- User property values must be 36 characters or fewer (only for `tool` name)
- Event names must be 40 characters or fewer, may only contain alpha-numeric characters and underscores, and must start with an alphabetic character
@eliasyishak
Merge branch 'conforming-ga-limitations' into main
2b26e92
@eliasyishak
Merge branch 'main' of https://github.com/eliasyishak/tools
16ba932
@eliasyishak
Moved creds + edit to tool regex pattern
25a1fb8
@eliasyishak
Merge branch 'dart-lang:main' into main
b16ffc5
@eliasyishak
Update to match main branch regex
41f00d5
@eliasyishak eliasyishak marked this pull request as ready for review February 28, 2023 17:13
@eliasyishak eliasyishak merged commit 2d9ebda into dart-lang:main Feb 28, 2023
@eliasyishak eliasyishak deleted the move-credentials branch February 28, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
package:source_maps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliasyishak @bwilkerson @mosuem