Skip to content

disable failing test #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

disable failing test #2136

merged 1 commit into from
Jul 29, 2025

Conversation

devoncarew
Copy link
Member


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew requested a review from kevmoo July 29, 2025 15:43
@devoncarew devoncarew requested a review from a team as a code owner July 29, 2025 15:43
Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
extension_discovery Breaking 2.1.0 2.1.0 3.0.0
Got "2.1.0" expected >= "3.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

@devoncarew devoncarew merged commit 607340c into dart-lang:main Jul 29, 2025
13 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 4, 2025
…, web, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/7fbe88a..72a9283):
  72a9283  2025-07-31  Jacob MacDonald  add --exclude-tool option to exclude tools by name (dart-lang/ai#253)
  0dbbd8b  2025-07-30  Jacob MacDonald  only run in shell when on windows and running a .bat file (dart-lang/ai#252)
  0858b0b  2025-07-28  Jacob MacDonald  further prompt refinement, discourage use of temp ids and encourage getting the widget tree often (dart-lang/ai#249)
  912c1f3  2025-07-28  Jacob MacDonald  release dart_mcp v0.3.3 (dart-lang/ai#247)
  0f7cba8  2025-07-28  Jacob MacDonald  add analytics tracking for prompts (dart-lang/ai#246)

dartdoc (https://github.com/dart-lang/dartdoc/compare/882aea9..414953e):
  414953ed  2025-08-04  Sam Rawlins  Simplify how inheritance is computed. (dart-lang/dartdoc#4079)

ecosystem (https://github.com/dart-lang/ecosystem/compare/d5233c6..2fe3618):
  2fe3618  2025-08-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/ecosystem#361)

protobuf (https://github.com/dart-lang/protobuf/compare/44ecd74..0b73b0d):
  0b73b0d  2025-07-30  Devon Carew  workspace, formatting, and proto version updates (google/protobuf.dart#1033)
  a664760  2025-07-30  Devon Carew  various CI workflow updates (google/protobuf.dart#1035)

test (https://github.com/dart-lang/test/compare/6aeb1e4..953e828):
  953e8282  2025-08-01  Nate Bosch  Drop executable arguments forwarding (dart-lang/test#2528)

tools (https://github.com/dart-lang/tools/compare/2a2a2d6..5e977d6):
  5e977d6f  2025-07-30  Jacob MacDonald  Fix mixtures of parentheses and spaces in windows command paths (dart-lang/tools#2138)
  607340ca  2025-07-29  Devon Carew  disable failing test (dart-lang/tools#2136)

vector_math (https://github.com/google/vector_math.dart/compare/13f185f..3939545):
  3939545  2025-08-04  Kevin Moore  Bump min SDK to 3.7, update dependencies, reformat (google/vector_math.dart#348)

web (https://github.com/dart-lang/web/compare/da1dd5d..1d5771b):
  1d5771b  2025-07-31  Nikechukwu  [interop] Add support for importing and exporting declarations, as well as multi-file output (dart-lang/web#418)

webdriver (https://github.com/google/webdriver.dart/compare/cfab787..595649d):
  595649d  2025-08-01  dependabot[bot]  Bump nanasess/setup-chromedriver (google/webdriver.dart#331)

Change-Id: Ia014bf6cafa9edcdaf453edda9cd5ecff516e16d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443625
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants