-
Notifications
You must be signed in to change notification settings - Fork 50
Update other session file create callsite #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update other session file create callsite #256
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
@@ -640,7 +640,7 @@ class AnalyticsImpl implements Analytics { | |||
// Recreate the session and client id file; no need to | |||
// recreate the log file since it will only receives events | |||
// to persist from events sent | |||
Initializer.createClientIdFile(clientFile: _clientIdFile); | |||
Initializer.createClientIdFile(clientIdFile: _clientIdFile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small correction to the spelling
@@ -49,7 +49,8 @@ class Session { | |||
if (now.difference(lastPingDateTime).inMinutes > kSessionDurationMinutes) { | |||
// Update the session file with the latest session id | |||
_sessionId = now.millisecondsSinceEpoch; | |||
sessionFile.writeAsStringSync('{"session_id": $_sessionId}'); | |||
sessionFile.writeAsStringSync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create a method that does this write, so we make sure to always keep the multiple call sites in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit to abstract the multliple writes to a method, but if you want to merge, publish, and then follow up with the refactor that SGTM.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.