Skip to content

write additional version info into the readme #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
`Node`.
- Deprecated `NodeGlue.append` in favor of `Node.appendChild`.
- Deprecated `NodeGlue.clone` in favor of `Node.cloneNode`.
- Updated to `@webref/css` `6.10.0`.

## 0.4.0

Expand Down
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,12 @@ void main() {

## Web IDL version

Based on:

<!-- START updated by tool/update_bindings.dart. Do not modify by hand -->
Based on [`@webref/idl 3.39.1`](https://www.npmjs.com/package/@webref/idl/v/3.39.1).
- @webref/idl [3.39.1](https://www.npmjs.com/package/@webref/idl/v/3.39.1)
- @webref/css [6.10.0](https://www.npmjs.com/package/@webref/css/v/6.10.0)
<!-- END updated by tool/update_bindings.dart. Do not modify by hand -->

For instructions on re-generating the DOM bindings, see
(bindings_generator/README.md)[bindings_generator/README.md].
[bindings_generator/README.md](bindings_generator/README.md).
2 changes: 1 addition & 1 deletion bindings_generator/generate_bindings.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Future<List<String>> _generateCSSStyleDeclarations() async {
if (properties != null) {
for (var j = 0; j < properties.length; j++) {
final property = properties[j] as CSSEntry;
// There are thre cases for [styleDeclaration]:
// There are three cases for [styleDeclaration]:
// 1) Length == 1, a single word CSS property.
// 2) Length == 2, a kebab case property + a camel case property.
// 3) Length == 3, webkit CSS properties.
Expand Down
15 changes: 9 additions & 6 deletions bindings_generator/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions bindings_generator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@
"author": "Dart project authors",
"license": "BSD 3",
"dependencies": {
"@webref/css": "^6.5.6",
"@webref/idl": "^3.23.0",
"@webref/css": "^6.10.0",
"@webref/idl": "^3.23.0"
},
"devDependencies": {
"web-specs": "^2.74.1",
"webidl2": "^24.2.2"
}
Expand Down
10 changes: 6 additions & 4 deletions lib/src/dom/cssom.dart
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
external String get alignItems;
external set alignSelf(String value);
external String get alignSelf;
external set alignTracks(String value);
external String get alignTracks;
external set alignmentBaseline(String value);
external String get alignmentBaseline;
external set all(String value);
Expand Down Expand Up @@ -295,6 +293,8 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
external String get backgroundRepeat;
external set backgroundSize(String value);
external String get backgroundSize;
external set backgroundTbd(String value);
external String get backgroundTbd;
external set baselineShift(String value);
external String get baselineShift;
external set baselineSource(String value);
Expand Down Expand Up @@ -603,6 +603,8 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
external String get dominantBaseline;
external set emptyCells(String value);
external String get emptyCells;
external set fieldSizing(String value);
external String get fieldSizing;
external set fill(String value);
external String get fill;
external set fillBreak(String value);
Expand Down Expand Up @@ -789,6 +791,8 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
external String get inputSecurity;
external set inset(String value);
external String get inset;
external set insetArea(String value);
external String get insetArea;
external set insetBlock(String value);
external String get insetBlock;
external set insetBlockEnd(String value);
Expand All @@ -809,8 +813,6 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
external String get justifyItems;
external set justifySelf(String value);
external String get justifySelf;
external set justifyTracks(String value);
external String get justifyTracks;
external set layoutOrder(String value);
external String get layoutOrder;
external set left(String value);
Expand Down
34 changes: 13 additions & 21 deletions tool/update_bindings.dart
Original file line number Diff line number Diff line change
Expand Up @@ -98,26 +98,18 @@ $_usage''');

final sourceContent = readmeFile.readAsStringSync();

final replaceRegexp = RegExp(
'''
${RegExp.escape(_startComment)}
.*
${RegExp.escape(_endComment)}
''',
multiLine: true,
);

final idlVersion = _webRefIdlVersion();

final idlReference = 'Based on [`$_webRefIdl $idlVersion`]'
'(https://www.npmjs.com/package/$_webRefIdl/v/$idlVersion).';

final newContent = sourceContent.replaceFirst(replaceRegexp, '''
final idlVersion = _packageLockVersion(_webRefIdl);
final cssVersion = _packageLockVersion(_webRefCss);
final versions = '''
$_startComment
$idlReference
$_endComment
''');
- $_webRefIdl [$idlVersion](https://www.npmjs.com/package/$_webRefIdl/v/$idlVersion)
- $_webRefCss [$cssVersion](https://www.npmjs.com/package/$_webRefCss/v/$cssVersion)
''';

final newContent =
sourceContent.substring(0, sourceContent.indexOf(_startComment)) +
versions +
sourceContent.substring(sourceContent.indexOf(_endComment));
if (newContent == sourceContent) {
print(ansi.styleBold.wrap('No update for readme.'));
} else {
Expand All @@ -126,21 +118,21 @@ $_endComment
}
}

String _webRefIdlVersion() {
String _packageLockVersion(String package) {
final packageLockData = jsonDecode(
File(p.join(_bindingsGeneratorPath, 'package-lock.json'))
.readAsStringSync(),
) as Map<String, dynamic>;

final packages = packageLockData['packages'] as Map<String, dynamic>;
final webRefIdl =
packages['node_modules/$_webRefIdl'] as Map<String, dynamic>;
final webRefIdl = packages['node_modules/$package'] as Map<String, dynamic>;
return webRefIdl['version'] as String;
}

const _bindingsGeneratorPath = 'bindings_generator';

const _webRefIdl = '@webref/idl';
const _webRefCss = '@webref/css';

const _thisScript = 'tool/update_bindings.dart';

Expand Down