Skip to content

switch CI to using workflow files #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2025
Merged

switch CI to using workflow files #428

merged 4 commits into from
Jul 24, 2025

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Jul 23, 2025 •
edited
Loading

  • switch CI to using workflow files
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew marked this pull request as ready for review July 24, 2025 00:02
@devoncarew devoncarew requested a review from srujzs July 24, 2025 00:03
@devoncarew devoncarew mentioned this pull request Jul 24, 2025
Merged
srujzs
srujzs approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this Devon! Just a few comments to make sure we're at parity with what we had before.

.github/workflows/web.yaml Outdated

- run: dart pub get
- run: dart format --output=none --set-exit-if-changed .
if: ${{ matrix.sdk == 'stable' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran dart format with dev as well before. I'd remove this (and it's okay if it runs with beta).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You generally just want to check formatting against one sdk version, for the infrequent times when the formatter changes output. I'll switch this to dev.

@devoncarew devoncarew mentioned this pull request Jul 24, 2025
Merged
devoncarew
devoncarew commented Jul 24, 2025
View reviewed changes
Copy link
Member Author

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Updated based on the feedback. I did keep the sdk version check for the formatting verification, just so we're only checking for formatting against a single sdk version.

.github/workflows/web.yaml Outdated

- run: dart pub get
- run: dart format --output=none --set-exit-if-changed .
if: ${{ matrix.sdk == 'stable' }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You generally just want to check formatting against one sdk version, for the infrequent times when the formatter changes output. I'll switch this to dev.

srujzs
srujzs approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@devoncarew devoncarew merged commit da1dd5d into main Jul 24, 2025
17 checks passed
@devoncarew devoncarew deleted the refactor_ci branch July 24, 2025 17:24
nikeokoronkwo added a commit to nikeokoronkwo/web that referenced this pull request Jul 30, 2025
@nikeokoronkwo
Squashed commit of the following:
452b566 
commit da1dd5d
Author: Devon Carew <[email protected]>
Date:   Thu Jul 24 10:24:40 2025 -0700

    switch CI to using workflow files (dart-lang#428)

    * switch CI to using workflow files

    * update the sdk matrix

    * review feedback

    * remove format sdk version check

commit 8ffaf5e
Author: Nikechukwu <[email protected]>
Date:   Wed Jul 23 12:17:55 2025 -0400

    [interop] Implement Diagnostics and Handling Errors (dart-lang#426)

    * implemented diagnostics

    * added extra invalid semantic
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 30, 2025
@devoncarew
[deps] rev ai, http, test, web
0de97d5 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/40607dc..7fbe88a):
  7fbe88a  2025-07-25  Jacob MacDonald  refine the prompt and fix the extension listener (dart-lang/ai#244)
  8d2384b  2025-07-25  Jacob MacDonald  add some intellij files to gitignore (dart-lang/ai#245)
  e09e469  2025-07-24  Jacob MacDonald  add prompt for using flutter driver to write a test for a user journey (dart-lang/ai#243)
  88d7a4d  2025-07-23  Jacob MacDonald  Flutter driver updates, add screenshot support back (dart-lang/ai#241)

http (https://github.com/dart-lang/http/compare/4a90d16..afda310):
  afda310  2025-07-23  Brian Quinlan  [cronet] Support aborting requests (dart-lang/http#1797)

test (https://github.com/dart-lang/test/compare/c201cc9..6aeb1e4):
  6aeb1e4f  2025-07-24  Nate Bosch  Consider NaN a match for itself (dart-lang/test#2524)
  65a37698  2025-07-23  Nate Bosch  Use latest analyzer and language version (dart-lang/test#2523)

web (https://github.com/dart-lang/web/compare/767151e..da1dd5d):
  da1dd5d  2025-07-24  Devon Carew  switch CI to using workflow files (dart-lang/web#428)
  8ffaf5e  2025-07-23  Nikechukwu  [interop] Implement Diagnostics and Handling Errors (dart-lang/web#426)

Change-Id: I499491c4c1466cb1c81cf5e4bbff4a484e880e57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442560
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
nikeokoronkwo added a commit that referenced this pull request Aug 6, 2025
@nikeokoronkwo
[web_generator] Add support for passing files as globs (#427)
f3c960f 
* added support for glob entries

* added support for properly working with dir globs

* changed ext to .idl

* minor fmt

* minor fixes

* Squashed commit of the following:

commit da1dd5d
Author: Devon Carew <[email protected]>
Date:   Thu Jul 24 10:24:40 2025 -0700

    switch CI to using workflow files (#428)

    * switch CI to using workflow files

    * update the sdk matrix

    * review feedback

    * remove format sdk version check

commit 8ffaf5e
Author: Nikechukwu <[email protected]>
Date:   Wed Jul 23 12:17:55 2025 -0400

    [interop] Implement Diagnostics and Handling Errors (#426)

    * implemented diagnostics

    * added extra invalid semantic

* added node version for web generator

* minor config fix

* updated node version to fix GHA bug

* changed `globSync` API to use string path rather than `fs.Dirent`

* formatting

* removed config test

* resolved commits

* fixed bug preventing files from being returned

* formatting and analyzing fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoncarew @srujzs