Refactor typeofEquals usage and remove isInstanceOfDomType #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will have to wait until we publish a Dart dev version >= this minimum. |
kevmoo
reviewed
Sep 26, 2023
srujzs
force-pushed
the
refactordartjsinterophelpers
branch
from
afd66d2 to
53fa83c
Compare
sigmundch
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Overall looks good, but I'd also be OK keeping a test like the one deleted in helpers_test. That's because, while technically the instnaceOfString should be tested by the SDK, there is still value in having a test here that ensures that it works for package:web types.
srujzs
force-pushed
the
refactordartjsinterophelpers
branch
from
53fa83c to
4c69a99
Compare
Fair point, added it back and refactored to account for |
srujzs
force-pushed
the
refactordartjsinterophelpers
branch
9 times, most recently
from
d6ffa98 to
5d79a7f
Compare
Closes dart-lang#77 typeofEquals now takes a String and returns a bool, and instanceOfString is the canonical replacement for isInstanceOfDomType. Updates min SDK version.
srujzs
force-pushed
the
refactordartjsinterophelpers
branch
from
5d79a7f to
5edbb85
Compare
srujzs
referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
typeofEquals now takes a String and returns a bool, and instanceOfString is the canonical replacement for isInstanceOfDomType. Removes now unneeded test as well. Updates min SDK version.