google3 updates required for version 22.0.0 #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

elliette opened this issue Sep 20, 2023 · 0 comments

Labels

Contributor

elliette commented Sep 20, 2023

Breaking changes included in DWDS 22.0.0:

Refactor: Update the parameters for DWDS.start #2231

The text was updated successfully, but these errors were encountered:

elliette added the package:dwds label

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue


          Update Webdev pin

c7d9d99

Pins DWDS to dart-lang/webdev@3078f48 which is necessary to unblock Dart SDK rollsdue to this change to the VM service interface: https://dart-review.googlesource.com/c/sdk/+/321660

Excludes dart-lang/webdev@d2dae56 which is a breaking change to DWDS.

Bug: dart-lang/webdev#2236
Change-Id: I3be3450901023dc5078f3aee1339ecf175908577
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327022
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue


          Remove webdev pin

87db2f8

Follow up to https://dart-review.googlesource.com/c/sdk/+/327022
DWDS breaking changes have been rolled into google3

Bug: dart-lang/webdev#2236
Change-Id: Ied4fa1dc73ec814cd3c667b3bc618e82e3d9e425
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/328402
Reviewed-by: Ben Konyi <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>

bkonyi closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment