Skip to content

Improve scope filtering heuristic #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2020
Merged

Improve scope filtering heuristic #1077

merged 2 commits into from
Jul 30, 2020

Conversation

grouma
Copy link
Member

@grouma grouma commented Jul 28, 2020

As of Dart SDK version 2.9.0-19.0.dev the Dart library scope is of the form import__. Update the filtering logic to use this new scope name.

@grouma grouma requested review from devoncarew and annagrin July 28, 2020 22:23
devoncarew
devoncarew approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I would wait for Anna's review as well

@grouma
Copy link
Member Author

grouma commented Jul 30, 2020

Merging on yellow as Travis Windows appears to be stuck.

@grouma grouma merged commit ad1ce09 into master Jul 30, 2020
@grouma grouma deleted the scope-filter branch July 30, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@annagrin annagrin Awaiting requested review from annagrin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grouma @devoncarew