Skip to content

Set breakpoints by regex URL #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 3, 2020
Merged

Set breakpoints by regex URL #1078

merged 6 commits into from
Aug 3, 2020

Conversation

grouma
Copy link
Member

@grouma grouma commented Jul 30, 2020

  • Use setBreakpointsByUrl to set breakpoints using a regex based on the module path
  • Chrome now handles re-establishing breakpoints upon refresh so remove the corresponding deprecated argument

Closes #1076

@grouma grouma changed the title [WIP] Set breakpoints by regex URL Set breakpoints by regex URL Jul 31, 2020
@grouma grouma requested review from annagrin and devoncarew July 31, 2020 16:14
@devoncarew
Copy link
Member

Chrome now handles re-establishing breakpoints upon restart

fyi for @bkonyi - package:dwds will attempt to auto-restore breakpoints after a hot restart; we'll want to coordinate this with DDS, so clients can know when auto-restore happens

@grouma
Copy link
Member Author

grouma commented Aug 3, 2020

fyi for @bkonyi - package:dwds will attempt to auto-restore breakpoints after a hot restart; we'll want to coordinate this with DDS, so clients can know when auto-restore happens

Yeah I was thinking through this a bit more. An alternative is to simply delete the breakpoints upon reload and manually add them back much like we do during a hot reload. We'll still want to use the updated setBreakpointByUrl API. I don't have a strong preference so I intend to leave it as is for now.

cc @jonahwilliams in case he may have concerns

@grouma
Copy link
Member Author

grouma commented Aug 3, 2020

Merging with a Windows flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Debugger.setBreakpointByUrl
2 participants