Skip to content

Fix webdev dependency of pre-release package #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

gmpassos
Copy link
Contributor

webdev was depending on a pre-release package!

Fix:

  • Rollback pre-release dependency of build_web_compilers: from 2.12.0-dev.1 to 2.11.0.

Rollback dependency (remove pre-release dependency):

from
 build_web_compilers: ^2.12.0-dev.1
to
  build_web_compilers: ^2.11.0
@jakemac53
Copy link
Contributor

Note that webdev does actually need this version of build_web_compilers - the tests are only passing here because where we run our e2e tests (the example dir) is actually requiring that pre-release version, so the tests are running with that.

If we removed the pre-release version constraint in the example/pubspec.yaml, this would likely not be passing (and that would mimic the behavior you all would get).

@gmpassos
Copy link
Contributor Author

gmpassos commented Sep 10, 2020

Are this new tests, with new scenarios that weren’t covered before? If yes, the current working version (2.5.9) will be equivalent to this pull request.

@jakemac53
Copy link
Contributor

Closing this one for now - we are working on a full rollback release in #1101

@jakemac53 jakemac53 closed this Sep 10, 2020
@jakemac53
Copy link
Contributor

Are this new tests, with new scenarios that weren’t covered before? If yes, the current working version (2.5.9) will be equivalent to this pull request.

The key issue here afaik is that the latest dwds package requires this pre-release build_web_compilers package, so we are rolling back the dep on the latest dwds to the previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants