Skip to content

Add an option to dwds to suppress emitting debug events #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

annagrin
Copy link
Contributor

Flutter sends a stream of debug events to dwds for profiling information
that can slow down debugging for apps that refresh frames frequently.

Add an option to disable debug events as a workaround until we can improve
performance of communication between the injected client and dwds.

Workaround for: #1466

Flutter sends a stream of debug events to dwds for profiling information
that can slow down debugging for apps that refresh frames frequently.

Add an option to disable debug events as a workaround until we can improve
performance of communication between the injected client and dwds.

Workaround for: dart-lang#1466
@annagrin annagrin requested a review from nshahan December 16, 2021 17:58
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments.

Overall I think we just need to be careful where we disable this so it's only for targets in settings that are not depending on any devtools. AFAIK this will break the Angular and Flutter dev tools.

@annagrin
Copy link
Contributor Author

annagrin commented Dec 16, 2021

AFAIK this will break the Angular and Flutter dev tools.

@nshahan do you know where are the debug events are used? I'd appreciate any pointers!

@annagrin annagrin merged commit 98d69bb into dart-lang:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants