DWDS only sends events if it has stats #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
Dec 16, 2021
| .difference(dwdsStats.devToolsStart) | ||
| .inMilliseconds)); | ||
| } | ||
| if (dwdsStats.debuggerStart != null) { |
There was a problem hiding this comment.
It looks like debuggerStart is always set, but adding this null check in case anything changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will hopefully fix #1468. It's hard to reproduce in a dev environment.
It looks like
devToolsStartis being set in two places:webdev/dwds/lib/src/handlers/dev_handler.dart
Line 367 in 95b3fd8
webdev/dwds/lib/src/handlers/dev_handler.dart
Line 515 in 95b3fd8
Both of which happen right before
_launchDevToolsis called. I believe this meansdevToolsStartis set when DevTools is launched programmatically (eg, by clicking on the Dart Debug Extension), but not when a user copy-pastes the link from their terminal.