Batch debug events sent from injected client to dwds #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 14, 2022 17:10
Flutter framework sends frequent frame events using `developer.postEvent`. In scenarios where we have to use SSE between the browser and dwds this leads to hign network load and slows down debugging. Batch and send debug events every 1000ms instead. Closes: dart-lang#1466
…tch_requests_extension
grouma
approved these changes
Jan 18, 2022
nshahan
reviewed
Jan 18, 2022
dwds/web/batched_stream.dart
Outdated
|
|
||
| var lastSendTime = DateTime.now().millisecondsSinceEpoch; | ||
| while (await _inputQueue.hasNext.timeout(duration, onTimeout: () => true)) { | ||
| if (await _inputQueue.hasNext.timeout(duration, onTimeout: () => false)) { |
There was a problem hiding this comment.
Can you add a comment for this conditional. I'm confused about what the logic here is doing.
There was a problem hiding this comment.
sure, this is trying not to pause batching until the next element arrives, times it instead.
There was a problem hiding this comment.
made helpers with explanatory names and added comments.
There was a problem hiding this comment.
+1 to adding a few comments in this method
dwds/web/client.dart
Outdated
| BatchedStreamController<DebugEvent>(delay: _batchDelayMilliseconds); | ||
| debugEventController.stream.listen((events) { | ||
| client.sink.add(jsonEncode(serializers.serialize(BatchedDebugEvents( | ||
| (b) => b..events = ListBuilder<DebugEvent>(events))))); |
There was a problem hiding this comment.
why the .. instead of . ?
There was a problem hiding this comment.
I can remove the extra dot it seems, thanks! The result of the closure parameter in the constructor of BatchedDebugEvents is not used it appears.
added 4 commits
January 21, 2022 09:54
kenzieschmoll
approved these changes
Jan 21, 2022
nshahan
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter framework sends frequent frame events using
developer.postEvent. In scenarios where we have touse SSE between the browser and dwds (possibly on a different machine) this leads to high network load and slows down debugging.
Batch and send debug events every 1000ms instead.
Closes: #1466