Fix issues in DevTools load time reporting #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store dwdsStats on appServices for an app to make sure we are updating an reporting the same stats for an app. Previously, if the app services already existed, we would use incorrect object to report the stats, causing incorrect times and missing reports. - Set the times on dwdsStats when debug request arrives to make sure times are recorded only from the time when the user starts debugging. - Process `pageReady` events from any DevTools page, as DevTools does not always show the debugger page first. - Enabled previously skipped tests. Closes:dart-lang#1517
elliette
approved these changes
Feb 22, 2022
added 2 commits
February 22, 2022 16:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating an reporting the same stats for an app. Previously,
if the app services already existed, we would use incorrect
object to report the stats, causing incorrect times and missing
reports.
sure times are recorded only from the time when the user starts
debugging.
pageReadyevents from any DevTools page, as DevToolsdoes not always show the debugger page first.
Closes:#1517