Skip to content

Modifies the update_dev_manifest script #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Aug 19, 2022

Previously, the script:

  • Added the Googler-only extension key (in a gitignored txt file) to the manifest.json (in the gitignored dev_build directory)
  • Changed the manifest.json icon from the normal icon to the dev icon

With this change, the script also:

  • Adds "[DEV]" to the start of the extension name to make it easy to distinguish from the non-dev version
  • Changes background.js to be background.dart.js for DDC
  • Changes the devtool.js file to prefix the Dart Debugger and Flutter Inspector panel names in Chrome DevTools with "[Dev]"

@elliette elliette requested a review from annagrin August 19, 2022 21:13
@elliette elliette requested a review from grouma August 23, 2022 01:04
@elliette elliette merged commit 2c158b5 into dart-lang:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants