Refactor Dart Debug Extension to add shared files for Chrome API and Web API wrappers #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Aug 23, 2022
| @@ -5,6 +5,7 @@ | |||
| import 'package:js/js.dart'; | |||
|
|
|||
| @JS() | |||
| // ignore: non_constant_identifier_names | |||
There was a problem hiding this comment.
I've re-factored the JS wrappers to match the native JS APIs (in this case, JSON.stringify). Because the JS class name is all-caps, we need to add the ignore comment.
(Before we weren't matching the JS APIs, so this was simply called stringify).
| @@ -298,13 +303,14 @@ void _maybeMarkTabAsDebuggable( | |||
| void _maybeAttachDebugSession( | |||
| Debuggee source, | |||
| String method, | |||
| Object params, | |||
| dynamic params, | |||
There was a problem hiding this comment.
Ah I think I changed to dynamic so it would be nullable. Switched to Object? instead
grouma
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background.dartand intochrome_api.dartandweb_api.dart(this way they can be used by both the service worker and IFRAME script for MV3 migration)chrome.debugger.onEvent.addListener)