Skip to content

Update package:vm_service constraints to allow version 14.x #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2024
+7 −3
Merged

Update package:vm_service constraints to allow version 14.x #2307

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9fdb9b
Update package:vm_service constraints to allow version 14.x
derekxu16 Dec 15, 2023
394a460
Change webdev version back to 3.3.0-wip
derekxu16 Dec 20, 2023
11f7764
Merge branch 'master' into update-vm-service-constraint
elliette Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -5,6 +5,8 @@
- Add `FrontendServerLegacyStrategyProvider` and update bootstrap generation logic for `LegacyStrategy` - [#2285](https://github.com/dart-lang/webdev/pull/2285)
- Tolerate failures to detect a Dart execution context. - [#2286](https://github.com/dart-lang/webdev/pull/2286)
- Fix a null cast error when debugging a `Class` from VS Code. - [#2303](https://github.com/dart-lang/webdev/pull/2303)
- Update `package:vm_service` constraint to `^14.0.0`. - [#2307](https://github.com/dart-lang/webdev/pull/2307)
- Update `package:vm_service_interface` constraint to `1.0.1`. - [#2307](https://github.com/dart-lang/webdev/pull/2307)

## 22.1.0
- Update `package:vm_service` constraint to `^13.0.0`. - [#2265](https://github.com/dart-lang/webdev/pull/2265)
4 changes: 2 additions & 2 deletions dwds/pubspec.yaml
View file
Original file line number Diff line number Diff line change
@@ -33,8 +33,8 @@ dependencies:
stack_trace: ^1.10.0
sse: ^4.1.2
uuid: ^3.0.6
vm_service: ^13.0.0
vm_service_interface: 1.0.0
vm_service: ^14.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this constraint can be loosened to >=13.0.0 <15.0.0 since the breaking changes in 14.0.0 aren't actually going to impact DWDS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do another release of dwds with the version constraint loosened?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this version of DWDS in the next stable release, I think so. We can't roll 14.0.0 through to Flutter yet since it'll break network profiling in DevTools until this SDK change lands.

vm_service_interface: 1.0.1
web_socket_channel: ^2.2.0
webkit_inspection_protocol: ^1.0.1

2 changes: 2 additions & 0 deletions webdev/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## 3.4.0-wip

- Update `package:vm_service` constraint to `>=10.1.0 <15.0.0`. - [#2307](https://github.com/dart-lang/webdev/pull/2307)

## 3.3.0

- Update `dwds` constraint to `23.0.0`.
2 changes: 1 addition & 1 deletion webdev/pubspec.yaml
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ dependencies:
shelf_static: ^1.1.0
stack_trace: ^1.10.0
sse: ^4.1.0
vm_service: ">=10.1.0 <14.0.0"
vm_service: ">=10.1.0 <15.0.0"
webkit_inspection_protocol: ^1.0.1
yaml: ^3.1.1