Skip to content

Add minimal bootstrapper for ddc_library_bundle format #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2024
Merged

Add minimal bootstrapper for ddc_library_bundle format #2523

merged 5 commits into from
Nov 25, 2024

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Nov 20, 2024 •
edited
Loading

Contains the following changes:

  • Bootstrapping scripts to load the needed scripts (including the module loader, dart_sdk, source maps, etc.) and to call main.
  • DDC library bundle load strategy that's mostly the DDC load strategy currently.
  • Fixes tests not passing canary feature flag.
  • Changes to the injected client to handle the new library format and use an unimplemented restarter for now.
  • Fixes some small formatting.

@srujzs
Add minimal bootstrapper for ddc_library_bundle format
4ba7690 
Contains the following changes:

- Bootstrapping scripts to load the needed scripts (including the
module loader, dart_sdk, source maps, etc.) and to call main.
- DDC library bundle load strategy that's mostly the DDC load strategy
currently.
- Fixes tests not passing canary feature flag.
- Changes to the injected client to handle the new library format and
use a no-op restarter for now.
- Fixes some small typos/formatting.
@srujzs
Update changelogs
f9e3f81
@srujzs
Add trailing comma
a840020
@srujzs
Revert extention -> extension change
475b9ba 
"EXTENTION" is used for bootstrapping in the build_runner which
will need to change for this change.
@srujzs srujzs requested review from Markzipan and jyameo November 21, 2024 17:28
@srujzs
Copy link
Contributor Author

srujzs commented Nov 21, 2024

The frontend_server_circular_evaluate_test failure seems to be pre-existing and it looks like https://dart-review.googlesource.com/c/sdk/+/396102 is the cause. I'll work on adding a fix/reverting for that separately.

jyameo
jyameo approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for figuring out this piece @srujzs 🎉 For the failing test, I see you already have a revert PR ready. I think once that PR is in and the test passes, you can submit this one to avoid any breakages

This was referenced Nov 21, 2024
Closed
Closed
Markzipan
Markzipan approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@Markzipan Markzipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bunch of this is still in iteration - and this just unblocks bootstrapping simple files. LGTM!

@srujzs
Copy link
Contributor Author

srujzs commented Nov 25, 2024

Thanks for the reviews!

@srujzs srujzs merged commit 1281e60 into dart-lang:main Nov 25, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyameo jyameo jyameo approved these changes

@Markzipan Markzipan Markzipan approved these changes

Assignees
No one assigned
Labels
package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srujzs @jyameo @Markzipan