handle org-dartlang-app library uris in dwds #381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
approved these changes
May 9, 2019
| @@ -49,5 +49,9 @@ dev_dependencies: | |||
| uuid: ^2.0.0 | |||
| webdriver: ^2.0.0 | |||
|
|
|||
| dependency_overrides: | |||
There was a problem hiding this comment.
Not required but I'm fine leaving it in if you want.
There was a problem hiding this comment.
Let's wait for #384 to land before merging this
alan-knight
approved these changes
May 9, 2019
natebosch
approved these changes
May 10, 2019
| @@ -803,13 +814,16 @@ function($argsString) { | |||
| } | |||
|
|
|||
| /// Runs an eval on the page to compute all the library names in the app. | |||
| Future<List<String>> _getLibraryNames() async { | |||
| Future<List<Uri>> _getLibraryUris() async { | |||
There was a problem hiding this comment.
[nit] https://dart.dev/guides/language/effective-dart/design#avoid-starting-a-method-name-with-get
Future<List<Uri>> get _libraryUris async {? Or maybe _transitiveLibraryUris?
|
I believe this is now obsolete, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only work with the latest edge sdk which returns the original
org-dartlang-appuris for libraries, and it will modify those uris to match up with the source map uris.Existing uris (which are just the basename of the file) are left untouched.