Use octomap also on Windows #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the compilation of the PR in conda-forge/dartsim-feedstock#28 (I did not merged it for conda-forge-related reason, but the compilation works fine. |
jslee02
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octomap support was disabled due to OctoMap/octomap#213, but that fix has been released a long time ago and all the octomap versions available in package managers used on Windows (vcplconda-forge, conan) include it.
Before creating a pull request
make format-DDART_TREAT_WARNINGS_AS_ERRORS=ONand resolve all the compile warningsBefore merging a pull request
CHANGELOG.md