build: bump Alpine version to 3.21 #2074
Conversation
|
Does not work, needs update of rocksdb on grovedb OR more work on c++ stack. |
WalkthroughThe Dockerfile has been updated to manage dependencies and adjust the build environment. Changes include updating the Alpine Linux base version, adding a new build argument, and correcting a build argument name. Modifications to package installation commands ensure that updated versions of clang and llvm are used and that the appropriate symbolic links and environment variables are set. Additional commands install curl in the Changes
Possibly related PRs
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (14)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lklimek
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.devcontainer/Dockerfile (1)
Line range hint
69-73: LGTM! Secure installation configurationThe wasm-bindgen-cli installation uses appropriate security flags. Consider adding a comment explaining the purpose of each flag for better maintainability.
RUN cargo binstall [email protected] --locked \ + # Ensure reproducible builds --no-discover-github-token \ + # Prevent automatic GitHub token discovery --disable-telemetry \ + # Disable usage tracking --no-track \ + # Additional tracking prevention --no-confirm + # Non-interactive installation
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (11)
.devcontainer/Dockerfile(1 hunks).github/workflows/release.yml(1 hunks).github/workflows/tests-build-js.yml(1 hunks)Dockerfile(4 hunks)README.md(1 hunks)packages/wasm-dpp/Cargo.toml(2 hunks)packages/wasm-dpp/README.md(1 hunks)packages/wasm-dpp/src/identity/factory_utils.rs(2 hunks)packages/wasm-dpp/src/identity/state_transition/asset_lock_proof/mod.rs(1 hunks)packages/wasm-dpp/src/identity/state_transition/identity_create_transition/identity_create_transition.rs(2 hunks)packages/wasm-dpp/src/identity/state_transition/identity_update_transition/identity_update_transition.rs(3 hunks)
👮 Files not reviewed due to content moderation or server errors (3)
- packages/wasm-dpp/src/identity/state_transition/asset_lock_proof/mod.rs
- .github/workflows/release.yml
- packages/wasm-dpp/src/identity/state_transition/identity_create_transition/identity_create_transition.rs
🔇 Additional comments (11)
packages/wasm-dpp/Cargo.toml (1)
18-18: Verify version synchronization across files
The wasm-bindgen and wasm-bindgen-futures versions have been updated. Let's verify that these versions are synchronized across all mentioned locations.
Also applies to: 52-52
✅ Verification successful
Let me check the exact version in the Dockerfile to ensure proper synchronization.
Versions are properly synchronized
The wasm-bindgen version 0.2.99 is consistently used across:
- packages/wasm-dpp/Cargo.toml:
wasm-bindgen = { version = "=0.2.99" } - .devcontainer/Dockerfile:
[email protected]
The wasm-bindgen-futures dependency was not found in the codebase, so the original review comment was partially incorrect in mentioning it.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check wasm-bindgen version consistency across files
echo "Checking wasm-bindgen version in build script..."
rg -l "wasm-bindgen.*0\.2\.(86|99)" packages/wasm-dpp/scripts/build-wasm.sh || echo "Version not found in build script"
echo "Checking wasm-bindgen version in Dockerfile..."
rg -l "wasm-bindgen-cli@0\.2\.(86|99)" .devcontainer/Dockerfile
echo "Checking wasm-bindgen version in Cargo.toml..."
rg "wasm-bindgen.*=.*0\.2\.(86|99)" packages/wasm-dpp/Cargo.toml
Length of output: 664
Script:
#!/bin/bash
# Get the exact version from Dockerfile
echo "Exact version in Dockerfile:"
rg -A 1 "wasm-bindgen-cli" .devcontainer/Dockerfile
# Also check for wasm-bindgen-futures version since it was mentioned
echo -e "\nChecking wasm-bindgen-futures version:"
rg "wasm-bindgen-futures.*=.*0\.2\." packages/wasm-dpp/Cargo.toml
Length of output: 405
packages/wasm-dpp/README.md (1)
42-44: LGTM! Installation instruction updated correctly
The wasm-bindgen-cli version has been updated to match the dependency version in Cargo.toml. The note about version verification is helpful for users.
.github/workflows/tests-build-js.yml (1)
53-53: Verify wasm-bindgen-cli version compatibility
The version update to 0.2.99 should be verified against other wasm-bindgen related dependencies in the project.
✅ Verification successful
Let me gather more information about the wasm-bindgen dependencies.
Version 0.2.99 of wasm-bindgen-cli is consistent with dependencies
The verification shows that the wasm-bindgen dependency in Cargo.toml is pinned to exactly version 0.2.99, which matches the CLI version being installed. This version is consistently referenced across the codebase in Dockerfile, READMEs, and Rust dependencies, indicating a coordinated update.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check wasm-bindgen version consistency across the project
# Look for wasm-bindgen dependencies in Cargo.toml files
rg -A 3 'wasm-bindgen = .*"0\.2\.' 'Cargo.toml$'
# Look for wasm-bindgen-cli version references
rg 'wasm-bindgen-cli.*0\.2\.'
Length of output: 469
Script:
#!/bin/bash
# Search for wasm-bindgen dependencies in all Cargo.toml files
fd Cargo.toml --exec cat {} | rg -A 3 'wasm-bindgen.*=.*'
# Search for any wasm-bindgen version references in package.json files
fd package.json --exec cat {} | rg 'wasm-bindgen'
Length of output: 632
packages/wasm-dpp/src/identity/factory_utils.rs (1)
49-52: LGTM! Clean type annotation removal
The removal of explicit type annotations improves code readability while maintaining type safety through Rust's type inference system.
Also applies to: 75-76
README.md (1)
64-64: Verify build prerequisites accuracy
The wasm-bindgen-cli version update is consistent with other changes. However, we should verify that:
- The version matches wasm-bindgen in Cargo.lock as noted
- All listed prerequisites and their versions are still accurate
✅ Verification successful
Prerequisites are accurate and consistent
The wasm-bindgen-cli version 0.2.99 matches exactly with the wasm-bindgen dependency version in packages/wasm-dpp/Cargo.toml. All other prerequisites in the README are up-to-date:
- Node.js v20 requirement is clearly specified
- Rust v1.83+ requirement is documented
- wasm32 target and wasm-bindgen toolchain instructions are accurate
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify wasm-bindgen version in Cargo.lock
rg '"wasm-bindgen"' Cargo.lock -A 2 | grep 'version'
# Check if prerequisites versions in README match workflow configurations
rg 'node\.?js.*v\d+' .github/workflows/
rg 'rust.*v\d+\.\d+' .github/workflows/
Length of output: 155
Script:
#!/bin/bash
# Let's verify the prerequisites more thoroughly
# Check wasm-bindgen-cli version in Cargo.toml and other dependencies
rg 'wasm-bindgen.*=.*0\.2\.99' -A 2
# Check Node.js version requirements in package.json and README
cat package.json | grep -A 2 '"engines"'
rg 'node' README.md
# Check Rust version requirements
rg 'rust' README.md
rg 'MSRV|minimal.*rust|minimum.*rust' -i
Length of output: 1234
packages/wasm-dpp/src/identity/state_transition/identity_update_transition/identity_update_transition.rs (3)
Line range hint 1-28: LGTM: Import organization looks good.
The imports are well-organized and necessary for the functionality.
88-91: LGTM: Improved type handling in public key mapping.
The code simplifies the mapping of JsValue to IdentityPublicKeyWithWitnessWasm with better type safety.
Line range hint 133-138: LGTM: Proper compiler configuration.
The CC and CXX environment variables are correctly set to use clang/clang++.
Dockerfile (3)
47-47: LGTM: Alpine version update.
Updating to Alpine 3.21 is a good choice as it has a longer EOL date (November 1, 2026) compared to 3.18 (November 1, 2025).
75-75: LGTM: Added missing curl package.
The addition of curl is necessary for downstream operations in the Dockerfile.
322-322: Verify compatibility with updated wasm-bindgen-cli version.
The update from wasm-bindgen-cli 0.2.86 to 0.2.99 is significant. While this aligns with the changes mentioned in the AI summary, we should verify compatibility.
✅ Verification successful
The wasm-bindgen-cli update is compatible with the codebase
The update from 0.2.86 to 0.2.99 is safe because:
- The wasm-bindgen dependency in Cargo.toml is explicitly pinned to version 0.2.99, matching the CLI version
- The wasm-bindgen-futures dependency is at 0.4.49 which is compatible with wasm-bindgen 0.2.99
- The project uses a custom fork of serde-wasm-bindgen that is designed to work with this version
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for breaking changes in wasm-bindgen-cli between versions
# Search for wasm-bindgen usage patterns that might be affected
rg -l 'wasm_bindgen' | while read -r file; do
echo "=== $file ==="
rg -A 5 'wasm_bindgen' "$file"
done
# Check Cargo.toml files for wasm-bindgen dependency versions
fd Cargo.toml | while read -r file; do
echo "=== $file ==="
rg 'wasm-bindgen' "$file"
done
Length of output: 131070
Script:
#!/bin/bash
# Search for wasm-bindgen dependency version in Cargo.toml files
fd Cargo.toml | while read -r file; do
echo "=== $file ==="
rg 'wasm-bindgen = ".*"' "$file"
done
# Search for wasm-bindgen-cli usage in build scripts
fd -e rs -e sh -e toml | while read -r file; do
echo "=== $file ==="
rg -i 'wasm-bindgen-cli' "$file"
done
Length of output: 131070
Script:
#!/bin/bash
# Search for wasm-bindgen version in package.json and Cargo.toml files
echo "=== Searching package.json for wasm-bindgen-cli version ==="
fd package.json | while read -r file; do
echo "=== $file ==="
rg '"wasm-bindgen-cli"' "$file"
done
echo "=== Searching Cargo.toml for wasm-bindgen version ==="
fd Cargo.toml | while read -r file; do
echo "=== $file ==="
rg 'wasm-bindgen = ".*"' "$file"
rg 'wasm-bindgen-cli = ".*"' "$file"
done
# Search for wasm-bindgen usage in build scripts
echo "=== Searching build scripts for wasm-bindgen-cli usage ==="
fd -e sh | while read -r file; do
echo "=== $file ==="
rg -i 'wasm-bindgen-cli' "$file"
done
Length of output: 15098
Script:
#!/bin/bash
# Check Dockerfile for wasm-bindgen-cli installation and version
echo "=== Checking Dockerfile for wasm-bindgen-cli installation ==="
rg -A 5 -B 5 'wasm-bindgen-cli' Dockerfile
# Check package.json and Cargo.toml in wasm-dpp package specifically
echo "=== Checking wasm-dpp package dependencies ==="
echo "=== packages/wasm-dpp/package.json ==="
cat packages/wasm-dpp/package.json | rg -i 'wasm-bindgen'
echo "=== packages/wasm-dpp/Cargo.toml ==="
cat packages/wasm-dpp/Cargo.toml | rg -i 'wasm-bindgen'
Length of output: 1821
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Dockerfile (2)
133-138: Improve compiler configuration setup.The compiler configuration is now explicitly set to use clang, which is good. However, consider moving these environment variables to a separate configuration file for better maintainability.
-RUN rm /usr/bin/cc && ln -s /usr/bin/clang /usr/bin/cc -RUN <<EOS -echo "export CXX='clang++'" >> /root/env -echo "export CC='clang'" >> /root/env -EOS +COPY compiler-config.env /root/compiler-config.env +RUN cat /root/compiler-config.env >> /root/env && \ + rm /usr/bin/cc && ln -s /usr/bin/clang /usr/bin/cc
Line range hint
644-644: Consider using multi-stage build for JS dependencies.The current approach copies all JS packages individually. Consider using a multi-stage build to copy all required packages at once, reducing the number of layers and improving maintainability.
-# TODO: Do one COPY with --parents -COPY --from=build-dashmate-helper /platform/.yarn /platform/.yarn +COPY --from=build-dashmate-helper /platform /platform/deps +RUN cp -r /platform/deps/.yarn /platform/ && \ + rm -rf /platform/depsAlso applies to: 645-645
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Release Drive debug image / Build linux/arm64 image
- GitHub Check: Release Drive debug image / Build linux/amd64 image
- GitHub Check: Release Drive image / Build linux/arm64 image
- GitHub Check: Release Drive image / Build linux/amd64 image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (4)
Dockerfile (4)
75-75: Good addition of curl package.Adding the
curlpackage is essential as it's a dependency for various download operations in the build process.
Line range hint
401-401: Critical: Update rocksdb version compatibility.Based on the PR comments, the current changes don't work due to rocksdb compatibility issues. The PR author mentioned that an update of rocksdb on grovedb is necessary.
Also applies to: 402-402
Line range hint
472-472: Verify wasm-bindgen-cli version compatibility.The wasm-bindgen-cli version has been updated to 0.2.99. Ensure this version is compatible with the rest of the toolchain.
✅ Verification successful
✓ wasm-bindgen version 0.2.99 is consistently configured across the toolchain
The version is properly synchronized between the Rust dependency, CLI tool, and build configuration, ensuring compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check wasm-bindgen version compatibility rg -A 5 "wasm-bindgen" . cargo tree -i wasm-bindgenLength of output: 14512
Line range hint
754-754: Security: Review ZMQ shared library installation.The ZeroMQ installation in the final dapi image should be reviewed for security implications. Consider pinning the version and scanning for known vulnerabilities.
Also applies to: 755-755
✅ Verification successful
ZeroMQ installation is secure in its current form
The current implementation using Alpine's package manager with a pinned Alpine version (3.21) is secure. No recent vulnerabilities have been reported, and the package is installed from official Alpine repositories which provide signed packages and security updates. While version pinning wasn't implemented directly, the Alpine version constraint provides adequate version control while allowing for security patches.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check ZMQ version and known vulnerabilities curl -s "https://dl-cdn.alpinelinux.org/alpine/v3.21/main/x86_64/APKINDEX.tar.gz" | tar -xz -O | grep -A5 "P:zeromq" # Check for any security advisories gh api graphql -f query=' { securityVulnerabilities(first: 5, ecosystem: ALPINE, package: "zeromq") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange } } }'Length of output: 876
Script:
#!/bin/bash # Check Dockerfile for ZMQ installation cat Dockerfile # Try different approach to get Alpine package info curl -s "https://dl-cdn.alpinelinux.org/alpine/v3.21/main/x86_64/APKINDEX.tar.gz" | tar -xz -O | strings | grep -A5 "P:zeromq" # Check GitHub security advisories with correct ecosystem gh api graphql -f query=' { securityVulnerabilities(first: 5, ecosystem: MAVEN, package: "org.zeromq") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange } } }'Length of output: 24992
Script:
#!/bin/bash # Check Alpine package info for zeromq curl -s "https://dl-cdn.alpinelinux.org/alpine/v3.21/main/x86_64/APKINDEX.tar.gz" | tar -xz -O | grep -a "P:zeromq" # Check CVE database for zeromq vulnerabilities curl -s "https://services.nvd.nist.gov/rest/json/cves/2.0?keywordSearch=zeromq&lastModStartDate=2023-01-01T00:00:00.000" | jq -r '.vulnerabilities[] | select(.cve.published >= "2023-01-01") | {id: .cve.id, published: .cve.published, description: .cve.descriptions[0].value}'Length of output: 412
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/rs-drive-abci/Cargo.toml (1)
118-119: LGTM! Lint configuration aligns with tokio_unstable usage concerns.The lint configuration will warn about unexpected usage of
tokio_unstablecfg flag, which aligns with the TODO comment about not using tokio_unstable in production.Would you like me to create an issue to track the TODO about removing tokio_unstable in production?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.cargo/config-release.toml(1 hunks).cargo/config.toml(1 hunks)Dockerfile(6 hunks)packages/rs-drive-abci/Cargo.toml(1 hunks)
🧰 Additional context used
📓 Learnings (1)
Dockerfile (1)
Learnt from: lklimek
PR: dashpay/platform#2074
File: Dockerfile:47-47
Timestamp: 2025-01-29T16:57:28.818Z
Learning: Alpine 3.21 is a stable release (released December 2024) and includes all required build dependencies with version suffixes (e.g., clang17-static, clang17-dev) instead of generic package names.
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (10)
.cargo/config-release.toml (2)
8-8: LGTM! CPU optimization flag aligns with build configuration.The addition of
-C target-cpu=x86-64-v3rustflag for x86_64-unknown-linux-musl target aligns with the CFLAGS/CXXFLAGS settings in the Dockerfile.
10-11: LGTM! Consistent CPU optimizations across targets.The new x86_64-unknown-linux-gnu target configuration mirrors the x86_64-unknown-linux-musl target settings, ensuring consistent CPU optimizations.
.cargo/config.toml (2)
7-14: LGTM! CPU optimization flag aligns with dev build configuration.The addition of
-C target-cpu=x86-64rustflag for x86_64-unknown-linux-musl target aligns with the CFLAGS/CXXFLAGS settings in the Dockerfile for dev builds.
16-24: LGTM! Consistent CPU optimizations across targets.The new x86_64-unknown-linux-gnu target configuration mirrors the x86_64-unknown-linux-musl target settings, ensuring consistent CPU optimizations.
Dockerfile (6)
47-47: LGTM! Alpine version update aligns with objectives.The update to Alpine 3.21 is appropriate as it's a stable release (released December 2024) with all required build dependencies and has an EOL date of November 1, 2026.
75-75: LGTM! Addition of curl package aligns with objectives.The addition of the curl package addresses the missing dependency requirement.
120-139: LGTM! CPU optimizations align with Rust configurations.The C/C++ compiler flags are properly configured based on architecture and build profile, aligning with the rustflags in the Cargo configurations.
152-157: LGTM! Proper clang configuration.The clang configuration is properly done by updating both the symlink and environment variables.
286-289: LGTM! Original CARGO_BUILD_PROFILE ARG.This is the correct location for the CARGO_BUILD_PROFILE ONBUILD ARG.
118-119:⚠️ Potential issueRemove duplicate ONBUILD ARG.
This ONBUILD ARG for CARGO_BUILD_PROFILE is a duplicate of the one at line 288.
Apply this diff to remove the duplicate:
-ONBUILD ARG CARGO_BUILD_PROFILE=dev -⛔ Skipped due to learnings
Learnt from: lklimek PR: dashpay/platform#2374 File: Dockerfile:117-118 Timestamp: 2024-12-16T08:59:40.338Z Learning: In our Dockerfiles, using `ONBUILD ARG CARGO_BUILD_PROFILE=dev` works correctly, and `CARGO_BUILD_PROFILE` is recognized in subsequent stages.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
Line range hint
1-731: Consider implementing parallel stage builds for optimization.The Dockerfile follows excellent practices with multi-stage builds, proper caching, and security considerations. To further optimize the build process, consider:
- Implementing parallel stage builds where possible (e.g.,
build-drive-abci,build-js, andbuild-dashmate-helpercould potentially run in parallel)- Using BuildKit's
--mount=type=cachemore extensively for npm/yarn cachesThis could significantly reduce build times in CI/CD pipelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(6 hunks)
🧰 Additional context used
📓 Learnings (1)
Dockerfile (1)
Learnt from: lklimek
PR: dashpay/platform#2074
File: Dockerfile:47-47
Timestamp: 2025-01-29T16:57:28.818Z
Learning: Alpine 3.21 is a stable release (released December 2024) and includes all required build dependencies with version suffixes (e.g., clang17-static, clang17-dev) instead of generic package names.
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
- GitHub Check: Rust crates security audit
🔇 Additional comments (5)
Dockerfile (5)
47-47: LGTM: Alpine version upgrade is appropriate.The upgrade to Alpine 3.21 is a good move as it extends the EOL support from November 2025 to November 2026.
Line range hint
118-160: Excellent optimization strategy for different architectures.The conditional optimization flags based on architecture and build profile is a good practice:
- x86-64-v3 for release builds on amd64
- x86-64 for dev builds on amd64
- Default settings for other architectures
289-292: LGTM: Build profile configuration is properly duplicated.The
CARGO_BUILD_PROFILEargument is correctly duplicated in both the base stage and rocksdb stage to ensure consistent build configuration throughout the multi-stage build.
493-493: Consider adding a newline for better readability.A newline has been added here which improves the visual separation between build stages.
73-80: Verify compiler toolchain compatibility.The upgrade to clang18/llvm18 packages is significant. While these are available in Alpine 3.21, we should verify compatibility with the Rust toolchain and rocksdb.
✅ Verification successful
Toolchain compatibility verified for Alpine 3.21
The clang18/llvm18 packages (version 18.1.8) are available in Alpine 3.21 and should be compatible with the build system. The codebase is designed to work with both system-provided and custom-installed LLVM toolchains, with no strict version requirements that would prevent using these packages.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if clang18 packages are available in Alpine 3.21 echo "Checking clang18 packages..." curl -s "https://dl-cdn.alpinelinux.org/alpine/v3.21/main/x86_64/APKINDEX.tar.gz" | tar -xz -O | grep -A1 "P:clang18" # Check if these versions are compatible with rocksdb echo "Checking rocksdb compatibility..." rg -A 5 "CLANG_VERSION|LLVM_VERSION"Length of output: 342
Script:
#!/bin/bash # Check Alpine packages properly echo "=== Checking Alpine packages ===" curl -s "https://dl-cdn.alpinelinux.org/alpine/v3.21/main/x86_64/APKINDEX.tar.gz" | tar -xzf - APKINDEX cat APKINDEX | grep -A3 "^P:clang18" cat APKINDEX | grep -A3 "^P:llvm18" echo -e "\n=== Checking build configurations ===" # Check CMake files for compiler requirements fd -e cmake -e txt -x cat {} echo -e "\n=== Checking Rust toolchain ===" # Check Rust toolchain specifications fd "rust-toolchain|rust-toolchain.toml" -x cat {} cat Cargo.toml 2>/dev/null || true echo -e "\n=== Checking build scripts ===" # Look for version constraints in build scripts fd "build.sh|compile.sh" -x cat {}Length of output: 94426
Script:
#!/bin/bash # Check RocksDB build requirements echo "=== Checking RocksDB build requirements ===" fd -e mk -e sh -e rs -x grep -l "CLANG\|LLVM\|CC\|CXX" {} | xargs cat 2>/dev/null || true echo -e "\n=== Checking Rust toolchain requirements ===" # Look for Rust toolchain specifications fd -e toml -x grep -l "rust\|RUST\|llvm\|LLVM\|clang\|CLANG" {} | xargs cat 2>/dev/null || true echo -e "\n=== Checking build system configurations ===" # Check build system configurations fd -e cmake -e mk -e sh -x grep -l "compiler\|COMPILER\|toolchain\|TOOLCHAIN" {} | xargs cat 2>/dev/null || trueLength of output: 67842
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(8 hunks)
🧰 Additional context used
📓 Learnings (1)
Dockerfile (1)
Learnt from: lklimek
PR: dashpay/platform#2074
File: Dockerfile:47-47
Timestamp: 2025-01-29T16:57:28.818Z
Learning: Alpine 3.21 is a stable release (released December 2024) and includes all required build dependencies with version suffixes (e.g., clang17-static, clang17-dev) instead of generic package names.
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: Release Drive image / Build linux/arm64 image
- GitHub Check: Release Drive debug image / Build linux/arm64 image
- GitHub Check: Release Drive image / Build linux/amd64 image
- GitHub Check: Release Drive debug image / Build linux/amd64 image
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (4)
Dockerfile (4)
47-47: LGTM! Alpine version upgrade is appropriate.The upgrade to Alpine 3.21 is a good choice as it:
- Extends EOL support by one year (until November 2026)
- Provides all required build dependencies
- Has been tested without breaking changes
75-75: LGTM! Essential curl package added.Adding
curlis necessary as it's used in various stages for downloading artifacts and interacting with APIs.
118-139: LGTM! Well-structured build configuration with appropriate optimizations.The changes introduce:
- Flexible build profiles with a sensible default
- Architecture-specific optimizations:
- x86-64-v3 for AMD64 release builds
- x86-64 for AMD64 debug builds
- Portable builds for other architectures
502-508: LGTM! Proper handling of compiler flags for wasm builds.Correctly unsets CFLAGS and CXXFLAGS to prevent architecture-specific optimizations from breaking wasm32 builds.
Also applies to: 555-562
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
291-292: Consider using dynamic thread count based on available memory.While using a single thread prevents OOM issues, it significantly increases build time. Consider implementing a dynamic approach:
-# Only use 1 thread to avoid OOM -export MAKEFLAGS='-j1' +# Use dynamic thread count based on available memory +export MAKEFLAGS="-j$(awk '/MemAvailable/ { printf "%.0f", $2/2097152 }' /proc/meminfo | sed 's/^0$/1/')"This will use approximately one thread per 2GB of available memory, with a minimum of 1 thread.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(8 hunks)
🧰 Additional context used
📓 Learnings (1)
Dockerfile (1)
Learnt from: lklimek
PR: dashpay/platform#2074
File: Dockerfile:47-47
Timestamp: 2025-01-29T16:57:28.818Z
Learning: Alpine 3.21 is a stable release (released December 2024) and includes all required build dependencies with version suffixes (e.g., clang17-static, clang17-dev) instead of generic package names.
🔇 Additional comments (4)
Dockerfile (4)
47-47: LGTM! Good proactive upgrade to Alpine 3.21.The upgrade from Alpine 3.18 to 3.21 extends the support window from November 2025 to November 2026, ensuring longer-term security updates and stability.
75-75: LGTM! Essential curl package added.The explicit addition of curl as a dependency is good practice, as it's required for downloading artifacts and interacting with external services.
120-139: LGTM! Well-structured architecture-specific optimizations.The configuration correctly sets optimization flags based on:
- Architecture (amd64 vs others)
- Build profile (release vs debug)
- For amd64: x86-64-v3 for release builds, x86-64 for debug builds
- For other architectures: PORTABLE=1
152-158: LGTM! Clean compiler configuration setup.The configuration properly:
- Sets up symbolic links for clang
- Exports CC and CXX environment variables
- Maintains flexibility for later updates (e.g., sccache integration)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
498-504: Consider refactoring duplicated wasm32 build configuration.The unset of CFLAGS/CXXFLAGS for wasm32 builds is duplicated in two places. Consider extracting this into a shared script or build arg to maintain DRY principles.
+ # Add at the top of the file + ARG WASM32_BUILD_SCRIPT='unset CFLAGS CXXFLAGS' - unset CFLAGS CXXFLAGS + $WASM32_BUILD_SCRIPTAlso applies to: 551-558
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(7 hunks)
🧰 Additional context used
📓 Learnings (1)
Dockerfile (1)
Learnt from: lklimek
PR: dashpay/platform#2074
File: Dockerfile:47-47
Timestamp: 2025-01-29T16:57:28.818Z
Learning: Alpine 3.21 is a stable release (released December 2024) and includes all required build dependencies with version suffixes (e.g., clang17-static, clang17-dev) instead of generic package names.
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Rust packages (drive-abci) / Unused dependencies
- GitHub Check: Rust packages (drive-abci) / Tests
- GitHub Check: Rust packages (drive-abci) / Formatting
- GitHub Check: Rust packages (drive-abci) / Linting
- GitHub Check: Rust packages (drive-abci) / Check each feature
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (4)
Dockerfile (4)
47-47: LGTM! Alpine version upgrade is well-justified.The upgrade from Alpine 3.18 to 3.21 extends the support timeline by a year (EOL: Nov 2026) while maintaining compatibility with all required build dependencies.
75-75: LGTM! The addition of curl package is necessary.The curl package is required for downloading various dependencies throughout the build process (toolchain, protoc, etc.).
152-158: LGTM! Compiler configuration improves build reproducibility.The explicit symlinks and environment variables ensure consistent compiler selection across different build scenarios.
125-138: Verify compatibility of x86-64-v3 optimization level.The CPU optimization strategy is sound, but x86-64-v3 might be too aggressive for some production environments. Please verify that:
- Target deployment environments support x86-64-v3 instruction set
- A fallback mechanism exists for incompatible systems
Run this script to check CPU feature requirements:
✅ Verification successful
CPU optimization strategy is well-designed and safe.
The implementation provides appropriate fallback mechanisms:
- Debug builds maintain base x86-64 compatibility
- Non-amd64 architectures automatically use portable mode
- Release builds with x86-64-v3 are limited to amd64 architecture only
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check x86-64-v3 CPU feature requirements echo "x86-64-v3 requires the following CPU features:" gcc -Q --help=target | grep -A15 "x86-64-v3 " echo -e "\nChecking if common cloud providers support x86-64-v3:" curl -s "https://cloud.google.com/compute/docs/cpu-platforms" | grep -B2 -A2 "AVX2" curl -s "https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/cpu-features.html" | grep -B2 -A2 "AVX2"Length of output: 549
Script:
#!/bin/bash # Search for CPU detection, build configs, and documentation echo "=== Searching for CPU detection or fallback mechanisms ===" rg -i "cpu|processor|x86[_-]64|march|target.*arch" --type rust -A 3 echo -e "\n=== Checking build configuration files ===" fd -e toml -x cat {} echo -e "\n=== Checking documentation for deployment requirements ===" fd "README|DEPLOY|INSTALL" -e md -e txt -x cat {}Length of output: 66658
commit 6776651 Author: QuantumExplorer <[email protected]> Date: Sat Mar 1 22:23:41 2025 +0700 chore: update to latest dash core 37 (#2483) commit 1501103 Merge: a7c7a0f da17fc5 Author: Ivan Shumkov <[email protected]> Date: Thu Feb 27 14:21:41 2025 +0700 chore: merge master and resolve conflicts (#2481) commit da17fc5 Author: pshenmic <[email protected]> Date: Thu Feb 27 13:31:51 2025 +0700 feat(js-dash-sdk): fix tests after merge commit c7e40cb Merge: c57e8b2 f9eb069 Author: Ivan Shumkov <[email protected]> Date: Thu Feb 27 09:35:02 2025 +0700 Merge remote-tracking branch 'origin/chore/merge-master' into chore/merge-master commit c57e8b2 Author: Ivan Shumkov <[email protected]> Date: Thu Feb 27 09:34:40 2025 +0700 test(dpp): fix assertion with the same value commit 045b6fa Author: Ivan Shumkov <[email protected]> Date: Thu Feb 27 09:32:33 2025 +0700 chore(dpp): remove unnecessary type conversion commit 8160ccd Author: Ivan Shumkov <[email protected]> Date: Thu Feb 27 09:31:32 2025 +0700 chore: remove duplicated commented code commit f9eb069 Merge: 05d0085 a7c7a0f Author: pshenmic <[email protected]> Date: Wed Feb 26 20:03:00 2025 +0700 Merge branch 'v2.0-dev' into chore/merge-master commit a7c7a0f Author: pshenmic <[email protected]> Date: Wed Feb 26 19:52:02 2025 +0700 build: bump rust version to 1.85 (#2480) commit 05d0085 Merge: bcf1785 196976c Author: Ivan Shumkov <[email protected]> Date: Wed Feb 26 18:03:38 2025 +0700 Merge branch 'master' into v2.0-dev commit bcf1785 Author: lklimek <[email protected]> Date: Fri Feb 21 08:43:35 2025 +0100 feat: wasm sdk build proof-of-concept (#2405) Co-authored-by: Ivan Shumkov <[email protected]> commit 5e32426 Author: Paul DeLucia <[email protected]> Date: Thu Feb 20 19:22:52 2025 +0700 fix: token already paused unpaused and frozen validation (#2466) commit 374a036 Author: Ivan Shumkov <[email protected]> Date: Thu Feb 20 17:46:57 2025 +0700 test: fix slowdown of JS SDK unit tests (#2475) commit 1fed09b Author: Ivan Shumkov <[email protected]> Date: Thu Feb 20 13:46:36 2025 +0700 fix(dpp): invalid feature flag usage (#2477) commit 33507bb Author: Paul DeLucia <[email protected]> Date: Thu Feb 20 13:18:55 2025 +0700 fix: destroy frozen funds used wrong identity and proof verification (#2467) commit 91a9766 Author: Ivan Shumkov <[email protected]> Date: Wed Feb 19 16:57:32 2025 +0700 feat(sdk): return state transition execution error (#2454) commit cb915a7 Author: Ivan Shumkov <[email protected]> Date: Wed Feb 19 16:46:54 2025 +0700 test: fix token history contract tests (#2470) commit 04276d5 Author: Ivan Shumkov <[email protected]> Date: Tue Feb 18 21:00:05 2025 +0700 fix: xss vulnerability in mocha (#2469) commit 196976c Author: pshenmic <[email protected]> Date: Fri Feb 14 18:50:08 2025 +0700 fix(sdk)!: bigint for uint64 values (#2443) commit 0bd29a6 Author: pshenmic <[email protected]> Date: Fri Feb 14 17:29:35 2025 +0700 feat(dpp): extra methods for state transitions in wasm (#2462) commit 1eae781 Author: pshenmic <[email protected]> Date: Fri Feb 14 15:29:17 2025 +0700 chore(platform): npm audit fix (#2463) commit ddf4e67 Author: Ivan Shumkov <[email protected]> Date: Fri Feb 14 11:28:08 2025 +0700 test: fix `fetchProofForStateTransition` tests and warnings (#2460) commit d88ea46 Author: Ivan Shumkov <[email protected]> Date: Fri Feb 14 09:52:53 2025 +0700 fix(dpp): invalid imports and tests (#2459) commit 82e4d4c Merge: 125cfe7 4becf5f Author: Paul DeLucia <[email protected]> Date: Thu Feb 13 19:05:51 2025 +0700 fix: check if token is paused on token transfers (#2458) commit 4becf5f Author: pauldelucia <[email protected]> Date: Thu Feb 13 18:34:24 2025 +0700 add costs commit 907971d Merge: 9026669 125cfe7 Author: Paul DeLucia <[email protected]> Date: Thu Feb 13 18:05:06 2025 +0700 Merge branch 'v2.0-dev' into feat/token-paused-validation commit 125cfe7 Merge: 91f65c6 c286ec0 Author: Ivan Shumkov <[email protected]> Date: Thu Feb 13 15:51:46 2025 +0700 Merge branch 'v2.0-dev' into v2.0-tokens-dev commit 9026669 Author: pauldelucia <[email protected]> Date: Thu Feb 13 13:41:19 2025 +0700 feat: check if token is paused on token transfers commit c286ec0 Author: pshenmic <[email protected]> Date: Wed Feb 12 15:41:21 2025 +0700 feat(sdk): add option to request all keys (#2445) commit 91f65c6 Merge: d6b40e6 1a1c50b Author: Paul DeLucia <[email protected]> Date: Wed Feb 12 12:04:58 2025 +0700 fix: wrong order of parameters in UnauthorizedTokenActionError (#2456) commit 1a1c50b Author: pauldelucia <[email protected]> Date: Wed Feb 12 11:51:31 2025 +0700 fix: wrong order of parameters in UnauthorizedTokenActionError commit 26aff36 Author: lklimek <[email protected]> Date: Tue Feb 11 13:06:54 2025 +0100 build: bump Alpine version to 3.21 (#2074) commit 9daa195 Author: Ivan Shumkov <[email protected]> Date: Tue Feb 11 14:38:55 2025 +0700 ci: use github-hosted arm runner for release workflow (#2452) commit 2b1c252 Author: Paul DeLucia <[email protected]> Date: Tue Feb 4 16:40:34 2025 +0700 fix: proof result error for credit transfers in sdk (#2451) commit d6b40e6 Author: QuantumExplorer <[email protected]> Date: Tue Feb 4 06:49:03 2025 +0700 feat(platform): token distribution part two (#2450) commit 93f7d44 Author: Ivan Shumkov <[email protected]> Date: Wed Jan 29 14:07:55 2025 +0700 fix(dpp): invalid feature flag instructions (#2448) commit 6d5af88 Author: QuantumExplorer <[email protected]> Date: Mon Jan 27 16:59:39 2025 +0700 feat(dpp): token distribution model (#2447) commit e735313 Author: Ivan Shumkov <[email protected]> Date: Mon Jan 27 14:24:26 2025 +0700 feat: add token transitions to SDK and DAPI (#2434) commit 0743be2 Author: pshenmic <[email protected]> Date: Sun Jan 26 22:00:40 2025 +0700 feat(dpp): extra methods for state transitions in wasm (#2401) commit f609bcf Merge: 3733f56 cbddb8d Author: Ivan Shumkov <[email protected]> Date: Fri Jan 24 18:16:38 2025 +0700 Merge branch 'v2.0-dev' into v2.0-tokens-dev commit cbddb8d Author: QuantumExplorer <[email protected]> Date: Fri Jan 24 17:59:16 2025 +0700 chore(platform): make bls sig compatibility an optional feature (#2440) Co-authored-by: Ivan Shumkov <[email protected]> commit 764684b Author: Ivan Shumkov <[email protected]> Date: Fri Jan 24 17:57:27 2025 +0700 chore: ignore deprecated `lodash.get` (#2441) commit 3733f56 Author: QuantumExplorer <[email protected]> Date: Thu Jan 23 09:16:12 2025 +0700 feat(platform)!: enhance token configuration and validation mechanisms (#2439) commit 2480ceb Author: QuantumExplorer <[email protected]> Date: Wed Jan 22 16:33:13 2025 +0700 chore: dapi grpc queries (#2437) commit c9ab154 Author: QuantumExplorer <[email protected]> Date: Wed Jan 22 15:50:25 2025 +0700 feat(platform)!: improved token validation and token config update transition (#2435) commit d9647cc Author: QuantumExplorer <[email protected]> Date: Tue Jan 21 10:28:58 2025 +0700 feat: get proofs for tokens (#2433) commit e5964b8 Author: QuantumExplorer <[email protected]> Date: Mon Jan 20 23:31:50 2025 +0700 feat: group queries (#2432) commit 0220302 Author: QuantumExplorer <[email protected]> Date: Sun Jan 19 14:43:51 2025 +0700 feat(platform): proof verification for many queries and a few more queries (#2431) commit cd1527d Author: QuantumExplorer <[email protected]> Date: Fri Jan 17 19:39:37 2025 +0700 fix(dpp)!: wrapping overflow issue (#2430) commit fd7ee85 Merge: d7143cc e4e156c Author: Ivan Shumkov <[email protected]> Date: Thu Jan 16 21:45:47 2025 +0700 Merge branch 'master' into v1.9-dev commit e4e156c Author: QuantumExplorer <[email protected]> Date: Thu Jan 16 18:11:57 2025 +0700 chore(release): update change log and release v1.8.0 (#2427) Co-authored-by: Ivan Shumkov <[email protected]> commit 55a1e03 Author: QuantumExplorer <[email protected]> Date: Thu Jan 16 15:30:42 2025 +0700 feat(platform)!: token base support (#2383) commit 59bf0af Author: QuantumExplorer <[email protected]> Date: Thu Jan 16 13:10:39 2025 +0700 chore(release): bump to v1.8.0-rc.2 (#2426) commit 410eb09 Author: QuantumExplorer <[email protected]> Date: Thu Jan 16 06:31:26 2025 +0700 fix(drive-abci): rebroadcasting should not only take first 2 quorums too (#2425) commit 2abce8e Author: Ivan Shumkov <[email protected]> Date: Wed Jan 15 22:51:58 2025 +0700 chore(release): update changelog and bump version to 1.8.0-rc.1 (#2423) commit ad5f604 Author: Ivan Shumkov <[email protected]> Date: Wed Jan 15 22:14:13 2025 +0700 chore: update bls library (#2424) commit c6feb5b Author: QuantumExplorer <[email protected]> Date: Wed Jan 15 18:57:49 2025 +0700 feat(platform)!: distribute prefunded specialized balances after vote (#2422) Co-authored-by: Ivan Shumkov <[email protected]> commit 94dcbb2 Author: Ivan Shumkov <[email protected]> Date: Wed Jan 15 05:51:45 2025 +0700 chore(drive): increase withdrawal limits to 2000 Dash per day (#2287) commit 6a0aede Author: Ivan Shumkov <[email protected]> Date: Tue Jan 14 21:42:59 2025 +0700 chore: fix test suite configuration script (#2402) commit e94b7bb Author: QuantumExplorer <[email protected]> Date: Tue Jan 14 19:23:46 2025 +0700 fix(drive-abci): document purchase on mutable document from different epoch had issue (#2420) commit 4ee57a6 Author: Ivan Shumkov <[email protected]> Date: Tue Jan 14 19:12:20 2025 +0700 fix(drive): more than one key was returned when expecting only one result (#2421) commit be5cd6d Author: Ivan Shumkov <[email protected]> Date: Mon Jan 13 15:12:33 2025 +0700 fix(sdk): failed to deserialize consensus error (#2410) commit e07271e Author: Ivan Shumkov <[email protected]> Date: Mon Jan 13 14:57:08 2025 +0700 chore: resolve NPM audit warnings (#2417) commit a809df7 Author: QuantumExplorer <[email protected]> Date: Sun Jan 12 09:21:48 2025 +0700 test: unify identity versioned cost coverage (#2416) commit 6d637fe Author: Paul DeLucia <[email protected]> Date: Fri Dec 27 09:42:04 2024 -0500 fix: try DriveDocumentQuery from DocumentQuery start field (#2407) commit cfd9c4d Author: Ivan Shumkov <[email protected]> Date: Thu Dec 19 18:30:06 2024 +0700 chore(release): update changelog and bump version to 1.8.0-dev.2 (#2404) commit fecda31 Merge: 37d5732 fc7d994 Author: Ivan Shumkov <[email protected]> Date: Thu Dec 19 15:33:45 2024 +0700 Merge branch 'master' into v1.8-dev commit fc7d994 Author: Ivan Shumkov <[email protected]> Date: Thu Dec 19 14:40:44 2024 +0700 chore(release): update changelog and bump version to 1.7.1 (#2403) commit adcd3b8 Author: QuantumExplorer <[email protected]> Date: Thu Dec 19 09:54:07 2024 +0300 fix!: emergency hard fork to fix masternode voting (#2397) commit 37d5732 Author: Ivan Shumkov <[email protected]> Date: Wed Dec 18 22:24:37 2024 +0700 fix(dashmate): some group commands fail with mtime not found (#2400) commit 01a5b7a Author: Ivan Shumkov <[email protected]> Date: Wed Dec 18 20:44:44 2024 +0700 refactor(dpp): using deprecated param to init wasm module (#2399) commit c5f5878 Author: Ivan Shumkov <[email protected]> Date: Wed Dec 18 18:04:14 2024 +0700 fix(dashmate): local network starting issues (#2394) commit 71c41ff Author: Ivan Shumkov <[email protected]> Date: Wed Dec 18 18:03:55 2024 +0700 perf(dpp): reduce JS binding size by 3x (#2396) commit 21ec393 Author: lklimek <[email protected]> Date: Wed Dec 18 10:47:58 2024 +0100 build!: update rust to 1.83 - backport #2393 to v1.7 (#2398) commit d7143cc Author: lklimek <[email protected]> Date: Wed Dec 18 08:53:53 2024 +0100 build!: optimize for x86-64-v3 cpu microarchitecture (Haswell+) (#2374) commit d318b1c Author: lklimek <[email protected]> Date: Tue Dec 17 14:56:15 2024 +0100 build: bump wasm-bindgen to 0.2.99 (#2395) commit 889d192 Author: Ivan Shumkov <[email protected]> Date: Tue Dec 17 19:25:58 2024 +0700 chore(release): update changelog and bump version to 1.8.0-dev.1 (#2391) commit 8185d21 Author: lklimek <[email protected]> Date: Tue Dec 17 10:47:53 2024 +0100 feat(sdk)!: allow setting CA cert (#1924) commit 82a6217 Author: lklimek <[email protected]> Date: Tue Dec 17 02:51:18 2024 +0100 build!: update rust to 1.83 (#2393) commit 494054a Author: QuantumExplorer <[email protected]> Date: Mon Dec 16 13:47:58 2024 +0300 refactor(platform): replace bls library (#2257) Co-authored-by: Lukasz Klimek <[email protected]> commit 4c203e4 Author: lklimek <[email protected]> Date: Mon Dec 16 10:38:34 2024 +0100 test(sdk): generate test vectors using testnet (#2381) commit 0ff6b27 Author: lklimek <[email protected]> Date: Mon Dec 16 10:37:35 2024 +0100 chore: remove deprecated check_network_version.sh (#2084) commit b265bb8 Author: lklimek <[email protected]> Date: Fri Dec 13 13:25:40 2024 +0100 ci: fix artifact upload issue on release build (#2389) commit 40ae73f Author: Ivan Shumkov <[email protected]> Date: Fri Dec 13 17:35:40 2024 +0700 chore(release): update changelog and bump version to 1.7.0 (#2387) commit 257e3da Author: Ivan Shumkov <[email protected]> Date: Fri Dec 13 15:44:10 2024 +0700 chore(dashmate)!: update Core to version 22 (#2384) commit 19a4c6d Author: Ivan Shumkov <[email protected]> Date: Thu Dec 12 18:30:14 2024 +0700 chore(dashmate): set tenderdash version to 1 (#2385) commit 0e9d4dc Author: lklimek <[email protected]> Date: Thu Dec 12 11:39:35 2024 +0100 chore: address vulnerabilty GHSA-mwcw-c2x4-8c55 (#2382) Co-authored-by: Ivan Shumkov <[email protected]> commit bdae90c Author: Ivan Shumkov <[email protected]> Date: Thu Dec 12 13:36:04 2024 +0700 chore(dashmate): increase subsidy for devnet (#2353)
Issue being fixed or feature implemented
Alpine 3.21 is the most recent version of Alpine, with EOL on 2026-11-01.
Current version (3.18) EOL is 2025-11-01, and it only gets security fixes atm.
What was done?
curlHow Has This Been Tested?
GHA https://github.com/dashpay/platform/actions/runs/13261874605
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit