Skip to content

Allow lazily evaluated TruncateSVD results #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eric-czech opened this issue Sep 15, 2020 · 0 comments · Fixed by #743
Closed

Allow lazily evaluated TruncateSVD results #740

eric-czech opened this issue Sep 15, 2020 · 0 comments · Fixed by #743

Comments

@eric-czech
Copy link
Contributor

I don't see any reason why the pca-specific parameters like these need to be computed immediately rather than leaving them as dask arrays:

components, ev, evr, sv = compute(v, explained_var, explained_variance_ratio, s)
self.components_ = components
self.explained_variance_ = ev
self.explained_variance_ratio_ = evr
self.singular_values_ = sv
self.n_features_in_ = X.shape[1]
return X_transformed

Is that true @TomAugspurger? I'd like to add a compute flag if that's ok. I'm guessing there is nothing in scikit-learn that would ever rely on those specific attributes.

eric-czech added a commit to eric-czech/dask-ml that referenced this issue Sep 21, 2020
eric-czech added a commit to eric-czech/dask-ml that referenced this issue Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant