Fix slow marker when conftest is missing. #1259
Conversation
The old fallback does not return anything, breaking anything that might be using the return value, like a marked parametrization.
QuLogic
changed the title
|
BTW, should conftest be in the PyPI tarball? |
| @@ -423,8 +423,7 @@ def disconnect_all(addresses, timeout=3): | |||
| not pytest.config.getoption("--runslow"), | |||
| reason="need --runslow option to run") | |||
| except (AttributeError, ValueError): | |||
| def slow(*args): | |||
| pass | |||
| slow = pytest.mark.slow | |||
There was a problem hiding this comment.
This could cause issues with downstream projects who import distributed and run tests with the --strict option. See pandas-dev/pandas#16680. The solution was to register the marker in our setup.cfg like https://github.com/pandas-dev/pandas/pull/16797/files. pandas does distributed our conftest.py, so maybe this change is OK.
There was a problem hiding this comment.
How about this gets moved to somewhere in tests? Right now this is broken when conftest.py is missing (like in the PyPI tarballs.)
|
Would this all be resolved if we distributed the conftest.py file? |
|
That's what pandas ended up doing. We had to since we have |
|
But does Pandas add an extra option? In Matplotlib, we couldn't add |
|
This PR has gone stale. Closing for now. |
The old fallback does not return anything, breaking anything that might be using the return value, like a marked parametrization.
An example is
test_dynamic_workloads_syncindistributed/tests/test_client.py.