WIP: Use Arrow for Pandas serialization #643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Nov 9, 2016
|
|
||
| def deserialize_pandas_series(header, frames): | ||
| df = deserialize_pandas_dataframe(header, frames) | ||
| return df[df.columns[0]] # unfortunate copy here |
There was a problem hiding this comment.
Ah indeed, my apologies.
jreback
reviewed
Nov 9, 2016
|
|
||
|
|
||
| def serialize_pandas_series(s): | ||
| return serialize_pandas_dataframe(s.to_frame()) # unfortunate copy here |
There was a problem hiding this comment.
this is also not s copy iirc (if i am not remembering correctly it's easy to make this not a copy)
|
for 1) you can do preserve index by if u want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds experimental support for custom Pandas serialization using Arrow.
There is some missing functionality here. I'm not sure if this is due to things missing within Arrow or my naive use of arrow (I'm just copy-pasting a solution from #614 ):
cc @wesm