-
-
Notifications
You must be signed in to change notification settings - Fork 733
Remove set_config when using default client #7482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 24 files + 13 24 suites +13 10h 36m 38s ⏱️ + 6h 58m 22s For more details on these failures, see this check. Results for commit 8229ff2. ± Comparison against base commit 0161991. ♻️ This comment has been updated with latest results. |
@@ -43,7 +43,7 @@ dependencies: | |||
- zict # overridden by git tip below | |||
- zstandard >=0.9.0 | |||
- pip: | |||
- git+https://github.com/dask/dask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Revert to dask/dask@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and reverted the temporary environment changes since the corresponding PRs in dask/dask
have been merged. Overall this looks good to me. The distributed/tests/test_client.py::test_default_get
test failure does look related though. From skimming the test, I'm inclined to just remove it. We definitely don't need the config checks anymore and the other checks in that that are, I think, covered over in the dask/dask
test suite (though please correct me if that's not the case)
Indeed, The The test is submitting a |
See for a change in dask/dask to fix the precedence. This is a regression we introduced in the last release dask/dask#9869 |
72d84ff
to
adb6433
Compare
I believe the test failures are unrelated. I'll go ahead and merge since this is quite deterministically failing a test in CI. I'm happy to come back and fix anything that's left |
Symmetric change to
distributed
default clients even if no config is set dask#9808Closes #7483
xref dask/dask#9807