Skip to content

test diff #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

test diff #369

wants to merge 4 commits into from

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented May 5, 2025

Tick one of the last boxes in the 2024.12 test coverage, #299

@ev-br ev-br mentioned this pull request Apr 23, 2025
Open
13 tasks
@ev-br
Copy link
Member Author

ev-br commented May 5, 2025

Am taking two shortcuts here:

  1. Only test integer dtypes. The spec stipulates that diff accepts arrays of numeric dtypes, so we should test that. The technical annoyance is Jax float64 precision issues do not play ball with hypothesis #368. Once it is solved, we'll need to update the tests here.
  2. Values testing is only for n=1.

Neither seems critical TBH.

Locally, ran tests with 10_000 examples for each of jax.numpy, cupy, numpy, torch and array_api-strict. All seem to square.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ev-br