Skip to content

test_take: test axis being optional if x.ndim==1 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

test_take: test axis being optional if x.ndim==1 #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b10aea5
Fix test_take to make axis optional when ndim == 1
asmeurer Jul 15, 2023
3bbe3d4
ENH: take: test axis<0
ev-br Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions array_api_tests/test_indexing_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,32 +17,39 @@
)
def test_take(x, data):
# TODO:
# * negative axis
# * negative indices
# * different dtypes for indices
axis = data.draw(st.integers(0, max(x.ndim - 1, 0)), label="axis")

# axis is optional but only if x.ndim == 1
_axis_st = st.integers(-x.ndim, max(x.ndim - 1, 0))
if x.ndim == 1:
kw = data.draw(hh.kwargs(axis=_axis_st))
else:
kw = {"axis": data.draw(_axis_st)}
axis = kw.get("axis", 0)
_indices = data.draw(
st.lists(st.integers(0, x.shape[axis] - 1), min_size=1, unique=True),
label="_indices",
)
n_axis = axis if axis>=0 else x.ndim + axis
indices = xp.asarray(_indices, dtype=dh.default_int)
note(f"{indices=}")

out = xp.take(x, indices, axis=axis)
out = xp.take(x, indices, **kw)

ph.assert_dtype("take", in_dtype=x.dtype, out_dtype=out.dtype)
ph.assert_shape(
"take",
out_shape=out.shape,
expected=x.shape[:axis] + (len(_indices),) + x.shape[axis + 1 :],
expected=x.shape[:n_axis] + (len(_indices),) + x.shape[n_axis + 1:],
kw=dict(
x=x,
indices=indices,
axis=axis,
),
)
out_indices = sh.ndindex(out.shape)
axis_indices = list(sh.axis_ndindex(x.shape, axis))
axis_indices = list(sh.axis_ndindex(x.shape, n_axis))
for axis_idx in axis_indices:
f_axis_idx = sh.fmt_idx("x", axis_idx)
for i in _indices:
Expand All @@ -62,7 +69,6 @@ def test_take(x, data):
next(out_indices)



@pytest.mark.unvectorized
@pytest.mark.min_version("2024.12")
@given(
Expand Down
Loading