-
Notifications
You must be signed in to change notification settings - Fork 53
Add accuracy document #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That does seem reasonable. For the test suite we'll still have to put in some absolute and relative tolerance w.r.t expected values though; those can be derived from libraries' existing test suites. Putting those numbers in the standard could make sense, but since they'd only be based on empirical evidence, it also wouldn't have much significance - mostly just serve as documentation. |
@rgommers Thanks for the review. Re: non-guidance. I think we have a couple of options.
|
In order to move this PR forward, I've added statements of non-guidance for statistical and linear algebra functions and added notes regarding test suite features for reporting mathematical function accuracy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, these explanation of why certain sets of functions cannot have a max accurary spec'ed and an approach of providing comparisons via the test suite is probably the best we can do for now. Merging.
This PR
Questions
Defining accuracy requirements for statistical and linear algebra APIs is a bit fraught, as it is hard to make general rules, in contrast to canonical mathematical functions. At the moment, I have left specification for these API areas as TODOs, and, atm, I am leaning toward non-guidance (i.e., "this standard does not specify accuracy requirements for (insert APIs) due to reasons X, Y, and Z; however, this standard does expect that conforming implementations will make a best-effort attempt to ensure their implementations are theoretically sound and numerically robust."