Add unique_counts() and fix the description of unique_all()
#317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
API extension
|
hmmm why does this PR only have 1 check instead of 3? |
kgryte
reviewed
Nov 5, 2021
kgryte
reviewed
Nov 5, 2021
|
@leofang Not sure why it has only one check. 🧐 |
My guess is the other two CIs only run for this repo's branches, not for branches from forks. There is a piece of permission bit that needs to be set (at least it's the case for GH actions). |
|
Ah, right. This was probably intentional in order to avoid drive-by PRs consuming resources. |
leofang
changed the title
unique_counts and apply a few fixes to unique_*() functionsunique_counts() and fix the description of unique_all()
|
I have reverted all changes on the returned integer type (discussion continued in #319) to make this PR easier to review 🙂 |
kgryte
reviewed
Nov 8, 2021
kgryte
reviewed
Nov 8, 2021
kgryte
approved these changes
Nov 8, 2021
|
Thanks, @kgryte, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #291.
This PR:
unique_countsas suggested in Addunique_counts()? #291 to return unique values and their corresponding countsuniqueAPIs:unique_all()was copied/pasted, which is now properly expandedthe "default integer type" mentions are not accurate if the index/count is too large. Now we allow type promotion as needed.UPDATE: discussion moved to The definition and discussion around "default array index data type" is missing #319.