Skip to content

Fix guidance for tensordot broadcasting #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2021
Merged

Fix guidance for tensordot broadcasting #324

merged 3 commits into from
Nov 9, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 8, 2021

This PR

  • resolves Should tensordot broadcast the contracted dimensions? #294 by fixing an ambiguity in the documentation which seemed to indicate that input arrays must be broadcast compatible across all dimensions. This indication was contradicted in later guidance which required that contracted dimensions must match. The changes proposed in this PR resolve this ambiguity by restricting broadcasting to only non-contracted dimensions.

@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. topic: Linear Algebra Linear algebra. labels Nov 8, 2021
@kgryte kgryte added this to the v2021 milestone Nov 8, 2021
@kgryte kgryte requested a review from asmeurer November 8, 2021 19:40
@kgryte kgryte removed the request for review from asmeurer November 9, 2021 20:59
@kgryte
Copy link
Contributor Author

kgryte commented Nov 9, 2021

Thanks, @leofang!

@kgryte kgryte merged commit 9efd1a3 into main Nov 9, 2021
@kgryte kgryte deleted the tensordot-broadcasting branch November 9, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.

Should tensordot broadcast the contracted dimensions?
2 participants
@kgryte @leofang