Add note clarifying behavior for out-of-bounds indices in take
#701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Narrative Content
|
@asmeurer As you are the original comment author, would you mind reviewing and signing off? Thanks! |
17 tasks
|
As this PR is a straightforward textual change which matches the language in the indexing specification, will go ahead and merge. @asmeurer If you have further comments, please feel free to open a new issue and we can address in a separate follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
take(see RFC: add APIs for getting elements via a list of indices (i.e.,take,take_along_axis, etc) #177 (comment)). Namely, a note is added to indicate that behavior for out-of-bounds indices is left unspecified. This is consistent with current guidance for integer indexing.